Skip to content

Impove imports #61908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Impove imports #61908

merged 1 commit into from
Jun 5, 2025

Conversation

kirjs
Copy link
Contributor

@kirjs kirjs commented Jun 5, 2025

Made all imports in the code relative/local
Made all the tests import from public_api file, this way we can see if something is not exported

@pullapprove pullapprove bot requested a review from josephperrott June 5, 2025 18:44
@kirjs kirjs changed the base branch from main to prototype/signal-forms June 5, 2025 18:45
* @param config Additional configuration
* - errors Optional - A function that takes FieldContext and returns one or more custom errors.
* - emptyPredicate Optional - A function that takes the value, and returns true if it's empty, false otherwise
* - condition Optional - A function that takes FieldContext and returns true if the field is required.
Copy link
Contributor

@michael-small michael-small Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-existing aside: condition is outdated, looks like this became when?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, I can fix this later, or feel free to send a PR

@ngbot ngbot bot added this to the Backlog milestone Jun 5, 2025
@kirjs kirjs force-pushed the impove-imports branch from 3d1da24 to 13bc5ea Compare June 5, 2025 19:25
@kirjs kirjs merged commit d953344 into angular:prototype/signal-forms Jun 5, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants