Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Commit 1328dfd

Browse files
nmccreadynmccready
committed
pr fixes via @cthrax comments
1 parent d81190b commit 1328dfd

11 files changed

+24
-37
lines changed

‎dist/angular-google-maps-street-view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! angular-google-maps 2.1.5 2015-08-16
1+
/*! angular-google-maps 2.1.5 2015-08-17
22
* AngularJS directives for Google Maps
33
* git: https://github.com/angular-ui/angular-google-maps.git
44
*/

‎dist/angular-google-maps-street-view.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps-street-view_dev_mapped.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps-street-view_dev_mapped.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! angular-google-maps 2.1.5 2015-08-16
1+
/*! angular-google-maps 2.1.5 2015-08-17
22
* AngularJS directives for Google Maps
33
* git: https://github.com/angular-ui/angular-google-maps.git
44
*/
@@ -3963,6 +3963,11 @@ Original idea from: http://stackoverflow.com/questions/22758950/google-map-drawi
39633963
}
39643964

39653965
BasePolysParentModel.prototype.watchModels = function(scope) {
3966+
3967+
/*
3968+
This was watchCollection but not all model changes were being caught.
3969+
TODO: Make the directive flexible in overriding whether we watch models (and depth) via watch or watchColleciton.
3970+
*/
39663971
return scope.$watch('models', (function(_this) {
39673972
return function(newValue, oldValue) {
39683973
if (newValue !== oldValue) {

‎dist/angular-google-maps.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps_dev_mapped.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! angular-google-maps 2.1.5 2015-08-16
1+
/*! angular-google-maps 2.1.5 2015-08-17
22
* AngularJS directives for Google Maps
33
* git: https://github.com/angular-ui/angular-google-maps.git
44
*/
@@ -3963,6 +3963,11 @@ Original idea from: http://stackoverflow.com/questions/22758950/google-map-drawi
39633963
}
39643964

39653965
BasePolysParentModel.prototype.watchModels = function(scope) {
3966+
3967+
/*
3968+
This was watchCollection but not all model changes were being caught.
3969+
TODO: Make the directive flexible in overriding whether we watch models (and depth) via watch or watchColleciton.
3970+
*/
39663971
return scope.$watch('models', (function(_this) {
39673972
return function(newValue, oldValue) {
39683973
if (newValue !== oldValue) {

‎dist/angular-google-maps_dev_mapped.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps_dev_mapped.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/angular-google-maps_dev_mapped.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)