Moved throwing an exception if $responsetring === "" , before the splitting(and parsing) of the response string.

frankmayer · frankmayer · commit 1be25d0c3e6e · 2017-02-16T15:34:12.000+02:00
diff --git a/lib/ArangoDBClient/HttpResponse.php b/lib/ArangoDBClient/HttpResponse.php
@@ -89,6 +89,14 @@ class HttpResponse
     public function __construct($responseString, $originUrl = null, $originMethod = null, $wasAsync = false)
     {
         $this->_wasAsync = $wasAsync;
+        if ($originUrl !== null && $originMethod !== null) {
+            if ($responseString === '') {
+                throw new ClientException(
+                    'Got no response from the server after request to '
+                    . $originMethod . ' ' . $originUrl . ' - Note: this may be a timeout issue'
+                );
+            }
+        }
 
         list($this->_header, $this->_body) = HttpHelper::parseHttpMessage($responseString, $originUrl, $originMethod);
         list($this->_httpCode, $this->_result, $this->_headers) = HttpHelper::parseHeaders($this->_header);
@@ -98,18 +106,11 @@ public function __construct($responseString, $originUrl = null, $originMethod =
         ) {
             // got no response body!
             if ($originUrl !== null && $originMethod !== null) {
-                if ($responseString === '') {
-                    throw new ClientException(
-                        'Got no response from the server after request to '
-                        . $originMethod . ' ' . $originUrl . ' - Note: this may be a timeout issue'
-                    );
-                }
                 throw new ClientException(
                     'Got an invalid response from the server after request to '
                     . $originMethod . ' ' . $originUrl
                 );
             }
-
             throw new ClientException('Got an invalid response from the server');
         }
     }
