squid:S2325 - private methods that don't access instance data should be static

Mohammed Ezzat · Mohammed Ezzat · commit 3791a80978d1 · 2016-02-22T19:15:51.000+02:00
diff --git a/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java b/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java
@@ -60,7 +60,7 @@ public void endDay() {
     makeActions(workers, DwarvenMineWorker.Action.GO_HOME, DwarvenMineWorker.Action.GO_TO_SLEEP);
   }
 
-  private void makeActions(Collection<DwarvenMineWorker> workers,
+  private static void makeActions(Collection<DwarvenMineWorker> workers,
       DwarvenMineWorker.Action... actions) {
     for (DwarvenMineWorker worker : workers) {
       worker.action(actions);
diff --git a/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java b/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java
@@ -44,7 +44,7 @@ private Command getCommand(String request) {
     }
   }
 
-  private Class getCommandClass(String request) {
+  private static Class getCommandClass(String request) {
     Class result;
     try {
       result = Class.forName("com.iluwatar.front.controller." + request + "Command");
diff --git a/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java b/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java
@@ -58,7 +58,7 @@ public void handleChannelRead(AbstractNioChannel channel, Object readObject, Sel
     }
   }
 
-  private void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {
+  private static void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {
     /*
      * Create a reply acknowledgement datagram packet setting the receiver to the sender of incoming
      * message.
@@ -69,12 +69,12 @@ private void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket
     channel.write(replyPacket, key);
   }
 
-  private void sendReply(AbstractNioChannel channel, SelectionKey key) {
+  private static void sendReply(AbstractNioChannel channel, SelectionKey key) {
     ByteBuffer buffer = ByteBuffer.wrap(ACK);
     channel.write(buffer, key);
   }
 
-  private void doLogging(ByteBuffer data) {
+  private static void doLogging(ByteBuffer data) {
     // assuming UTF-8 :(
     System.out.println(new String(data.array(), 0, data.limit()));
   }
diff --git a/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java b/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java
@@ -186,7 +186,7 @@ private void processKey(SelectionKey key) throws IOException {
     }
   }
 
-  private void onChannelWritable(SelectionKey key) throws IOException {
+  private static void onChannelWritable(SelectionKey key) throws IOException {
     AbstractNioChannel channel = (AbstractNioChannel) key.attachment();
     channel.flush(key);
   }
diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java
@@ -89,7 +89,7 @@ private boolean isLockFree() {
     return globalMutex.isEmpty();
   }
 
-  private void waitUninterruptibly(Object o) {
+  private static void waitUninterruptibly(Object o) {
     try {
       o.wait();
     } catch (InterruptedException e) {
diff --git a/repository/src/main/java/com/iluwatar/repository/AppConfig.java b/repository/src/main/java/com/iluwatar/repository/AppConfig.java
@@ -76,7 +76,7 @@ public LocalContainerEntityManagerFactoryBean entityManagerFactory() {
   /**
    * Properties for Jpa
    */
-  private Properties jpaProperties() {
+  private static Properties jpaProperties() {
     Properties properties = new Properties();
     properties.setProperty("hibernate.dialect", "org.hibernate.dialect.H2Dialect");
     properties.setProperty("hibernate.hbm2ddl.auto", "create-drop");

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public void endDay() {`
`60`	`60`	`makeActions(workers, DwarvenMineWorker.Action.GO_HOME, DwarvenMineWorker.Action.GO_TO_SLEEP);`
`61`	`61`	`}`
`62`	`62`
`63`		`- private void makeActions(Collection<DwarvenMineWorker> workers,`
	`63`	`+ private static void makeActions(Collection<DwarvenMineWorker> workers,`
`64`	`64`	`DwarvenMineWorker.Action... actions) {`
`65`	`65`	`for (DwarvenMineWorker worker : workers) {`
`66`	`66`	`worker.action(actions);`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private Command getCommand(String request) {`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`47`		`- private Class getCommandClass(String request) {`
	`47`	`+ private static Class getCommandClass(String request) {`
`48`	`48`	`Class result;`
`49`	`49`	`try {`
`50`	`50`	`result = Class.forName("com.iluwatar.front.controller." + request + "Command");`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public void handleChannelRead(AbstractNioChannel channel, Object readObject, Sel`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`- private void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {`
	`61`	`+ private static void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {`
`62`	`62`	`/*`
`63`	`63`	`* Create a reply acknowledgement datagram packet setting the receiver to the sender of incoming`
`64`	`64`	`* message.`
`@@ -69,12 +69,12 @@ private void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket`
`69`	`69`	`channel.write(replyPacket, key);`
`70`	`70`	`}`
`71`	`71`
`72`		`- private void sendReply(AbstractNioChannel channel, SelectionKey key) {`
	`72`	`+ private static void sendReply(AbstractNioChannel channel, SelectionKey key) {`
`73`	`73`	`ByteBuffer buffer = ByteBuffer.wrap(ACK);`
`74`	`74`	`channel.write(buffer, key);`
`75`	`75`	`}`
`76`	`76`
`77`		`- private void doLogging(ByteBuffer data) {`
	`77`	`+ private static void doLogging(ByteBuffer data) {`
`78`	`78`	`// assuming UTF-8 :(`
`79`	`79`	`System.out.println(new String(data.array(), 0, data.limit()));`
`80`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ private void processKey(SelectionKey key) throws IOException {`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`
`189`		`- private void onChannelWritable(SelectionKey key) throws IOException {`
	`189`	`+ private static void onChannelWritable(SelectionKey key) throws IOException {`
`190`	`190`	`AbstractNioChannel channel = (AbstractNioChannel) key.attachment();`
`191`	`191`	`channel.flush(key);`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ private boolean isLockFree() {`
`89`	`89`	`return globalMutex.isEmpty();`
`90`	`90`	`}`
`91`	`91`
`92`		`- private void waitUninterruptibly(Object o) {`
	`92`	`+ private static void waitUninterruptibly(Object o) {`
`93`	`93`	`try {`
`94`	`94`	`o.wait();`
`95`	`95`	`} catch (InterruptedException e) {`