Mark some MemoryStream usages non-writable

peterdettman · peterdettman · commit d11b09d4e165 · 2025-07-29T22:20:21.000+07:00
diff --git a/crypto/src/bcpg/SignaturePacket.cs b/crypto/src/bcpg/SignaturePacket.cs
@@ -385,7 +385,7 @@ private void SetCreationTime()
 
         public static SignaturePacket FromByteArray(byte[] data)
         {
-            BcpgInputStream input = BcpgInputStream.Wrap(new MemoryStream(data));
+            BcpgInputStream input = BcpgInputStream.Wrap(new MemoryStream(data, writable: false));
 
             return new SignaturePacket(input);
         }
diff --git a/crypto/src/openpgp/PgpSecretKeyRing.cs b/crypto/src/openpgp/PgpSecretKeyRing.cs
@@ -36,7 +36,7 @@ private PgpSecretKeyRing(
 
         public PgpSecretKeyRing(
             byte[] encoding)
-            : this(new MemoryStream(encoding))
+            : this(new MemoryStream(encoding, writable: false))
         {
         }
 
diff --git a/crypto/src/tls/TlsExtensionsUtilities.cs b/crypto/src/tls/TlsExtensionsUtilities.cs
@@ -981,7 +981,7 @@ public static IList<ProtocolName> ReadAlpnExtensionClient(byte[] extensionData)
             if (extensionData == null)
                 throw new ArgumentNullException(nameof(extensionData));
 
-            MemoryStream buf = new MemoryStream(extensionData);
+            MemoryStream buf = new MemoryStream(extensionData, writable: false);
 
             int length = TlsUtilities.ReadUint16(buf);
             if (length != (extensionData.Length - 2))
@@ -1015,7 +1015,7 @@ public static IList<X509Name> ReadCertificateAuthoritiesExtension(byte[] extensi
             if (extensionData.Length < 5)
                 throw new TlsFatalAlert(AlertDescription.decode_error);
 
-            MemoryStream buf = new MemoryStream(extensionData);
+            MemoryStream buf = new MemoryStream(extensionData, writable: false);
 
             int length = TlsUtilities.ReadUint16(buf);
             if (length != (extensionData.Length - 2))

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ private void SetCreationTime()`
`385`	`385`
`386`	`386`	`public static SignaturePacket FromByteArray(byte[] data)`
`387`	`387`	`{`
`388`		`- BcpgInputStream input = BcpgInputStream.Wrap(new MemoryStream(data));`
	`388`	`+ BcpgInputStream input = BcpgInputStream.Wrap(new MemoryStream(data, writable: false));`
`389`	`389`
`390`	`390`	`return new SignaturePacket(input);`
`391`	`391`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ private PgpSecretKeyRing(`
`36`	`36`
`37`	`37`	`public PgpSecretKeyRing(`
`38`	`38`	`byte[] encoding)`
`39`		`- : this(new MemoryStream(encoding))`
	`39`	`+ : this(new MemoryStream(encoding, writable: false))`
`40`	`40`	`{`
`41`	`41`	`}`
`42`	`42`