Skip to content

Commit 8372f9d

Browse files
committed
Merge pull request symfony#1937 from richardmiller/changing_we_use_misc
Changing some uses of we/let's/our
2 parents cfdfb95 + 868b73a commit 8372f9d

File tree

22 files changed

+88
-88
lines changed

22 files changed

+88
-88
lines changed

book/controller.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ a serialized JSON array, an image, a redirect, a 404 error or anything else
1111
you can dream up. The controller contains whatever arbitrary logic *your
1212
application* needs to render the content of a page.
1313

14-
To see how simple this is, let's look at a Symfony2 controller in action.
14+
See how simple this is, by looking at a Symfony2 controller in action.
1515
The following controller would render a page that simply prints ``Hello world!``::
1616

1717
use Symfony\Component\HttpFoundation\Response;
@@ -115,7 +115,7 @@ a controller object. Controllers are also called *actions*.
115115
will house several controllers/actions (e.g. ``updateAction``, ``deleteAction``,
116116
etc).
117117

118-
This controller is pretty straightforward, but let's walk through it:
118+
This controller is pretty straightforward:
119119

120120
* *line 4*: Symfony2 takes advantage of PHP 5.3 namespace functionality to
121121
namespace the entire controller class. The ``use`` keyword imports the

book/doctrine.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Databases and Doctrine
55
======================
66

7-
Let's face it, one of the most common and challenging tasks for any application
7+
One of the most common and challenging tasks for any application
88
involves persisting and reading information to and from a database. Fortunately,
99
Symfony comes integrated with `Doctrine`_, a library whose sole goal is to
1010
give you powerful tools to make this easy. In this chapter, you'll learn the
@@ -418,7 +418,7 @@ of the bundle:
418418
If you're following along with this example, you'll need to create a
419419
route that points to this action to see it work.
420420

421-
Let's walk through this example:
421+
Walking through this example:
422422

423423
* **lines 9-12** In this section, you instantiate and work with the ``$product``
424424
object like any other, normal PHP object.
@@ -963,7 +963,7 @@ table, and ``product.category_id`` column, and new foreign key:
963963
Saving Related Entities
964964
~~~~~~~~~~~~~~~~~~~~~~~
965965

966-
Now, let's see the code in action. Imagine you're inside a controller::
966+
Now, to see the code in action. Imagine you're inside a controller::
967967

968968
// ...
969969

book/forms.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ the correct values of a number of field options.
524524
* ``max_length``: If the field is some sort of text field, then the ``max_length``
525525
option can be guessed from the validation constraints (if ``MaxLength`` or ``Max``
526526
is used) or from the Doctrine metadata (via the field's length).
527-
527+
528528
.. note::
529529

530530
These field options are *only* guessed if you're using Symfony to guess
@@ -576,7 +576,7 @@ of code. Of course, you'll usually need much more flexibility when rendering:
576576
<input type="submit" />
577577
</form>
578578

579-
Let's take a look at each part:
579+
Taking a look at each part:
580580

581581
* ``form_enctype(form)`` - If at least one field is a file upload field, this
582582
renders the obligatory ``enctype="multipart/form-data"``;
@@ -1029,7 +1029,7 @@ In PHP, each form "fragment" is rendered via an individual template file.
10291029
To customize any part of how a form renders, you just need to override the
10301030
existing template by creating a new one.
10311031

1032-
To understand how this works, let's customize the ``form_row`` fragment and
1032+
To understand how this works, customize the ``form_row`` fragment and
10331033
add a class attribute to the ``div`` element that surrounds each row. To
10341034
do this, create a new template file that will store the new markup:
10351035

@@ -1259,7 +1259,7 @@ to define form output.
12591259
ever be needed in a single template.
12601260

12611261
.. caution::
1262-
1262+
12631263
This ``{% form_theme form _self %}`` functionality will *only* work
12641264
if your template extends another. If your template does not, you
12651265
must point ``form_theme`` to a separate template.

book/installation.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ something like this:
7575
7676
.. note::
7777

78-
You can easily override the default directory structure. See
79-
:doc:`/cookbook/configuration/override_dir_structure` for more
78+
You can easily override the default directory structure. See
79+
:doc:`/cookbook/configuration/override_dir_structure` for more
8080
information.
8181

8282
Updating Vendors
@@ -135,9 +135,9 @@ If there are any issues, correct them now before moving on.
135135
136136
**2. Using Acl on a system that does not support chmod +a**
137137

138-
Some systems don't support ``chmod +a``, but do support another utility
138+
Some systems don't support ``chmod +a``, but do support another utility
139139
called ``setfacl``. You may need to `enable ACL support`_ on your partition
140-
and install setfacl before using it (as is the case with Ubuntu), like
140+
and install setfacl before using it (as is the case with Ubuntu), like
141141
so:
142142

143143
.. code-block:: bash
@@ -188,7 +188,7 @@ development! Your distribution may contain some sample code - check the
188188
to learn about what sample code was included with your distribution and how
189189
you can remove it later.
190190

191-
If you're new to Symfony, join us in the ":doc:`page_creation`", where you'll
191+
If you're new to Symfony, look at ":doc:`page_creation`", where you'll
192192
learn how to create pages, change configuration, and do everything else you'll
193193
need in your new application.
194194

book/service_container.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ you need it::
7979
$mailer = new Mailer('sendmail');
8080
$mailer->send('ryan@foobar.net', ...);
8181

82-
This is easy enough. The imaginary ``Mailer`` class allows us to configure
82+
This is easy enough. The imaginary ``Mailer`` class allows you to configure
8383
the method used to deliver the email messages (e.g. ``sendmail``, ``smtp``, etc).
8484
But what if you wanted to use the mailer service somewhere else? You certainly
8585
don't want to repeat the mailer configuration *every* time you need to use
@@ -578,7 +578,7 @@ This approach is fine, but what if you decide later that the ``NewsletterManager
578578
class needs a second or third constructor argument? What if you decide to
579579
refactor our code and rename the class? In both cases, you'd need to find every
580580
place where the ``NewsletterManager`` is instantiated and modify it. Of course,
581-
the service container gives us a much more appealing option:
581+
the service container gives you a much more appealing option:
582582

583583
.. configuration-block::
584584

components/console/introduction.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ You can install the component in many different ways:
2323
Creating a basic Command
2424
------------------------
2525

26-
To make a console command to greet us from the command line, create ``GreetCommand.php``
26+
To make a console command to greet you from the command line, create ``GreetCommand.php``
2727
and add the following to it::
2828

2929
namespace Acme\DemoBundle\Command;
@@ -451,4 +451,4 @@ Learn More!
451451
* :doc:`/components/console/usage`
452452
* :doc:`/components/console/single_command_tool`
453453

454-
.. _Packagist: https://packagist.org/packages/symfony/console
454+
.. _Packagist: https://packagist.org/packages/symfony/console

components/dom_crawler.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ Links
179179

180180
To find a link by name (or a clickable image by its ``alt`` attribute), use
181181
the ``selectLink`` method on an existing crawler. This returns a Crawler
182-
instance with just the selected link(s). Calling ``link()`` gives us a special
182+
instance with just the selected link(s). Calling ``link()`` gives you a special
183183
:class:`Symfony\\Component\\DomCrawler\\Link` object::
184184

185185
$linksCrawler = $crawler->selectLink('Go elsewhere...');
@@ -319,4 +319,4 @@ directly::
319319
$crawler = $client->submit($form);
320320

321321
.. _`Goutte`: https://github.com/fabpot/goutte
322-
.. _Packagist: https://packagist.org/packages/symfony/dom-crawler
322+
.. _Packagist: https://packagist.org/packages/symfony/dom-crawler

contributing/code/conventions.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ is a main relation:
3232
* a ``CookieJar`` has many ``Cookie`` objects;
3333

3434
* a Service ``Container`` has many services and many parameters (as services
35-
is the main relation, we use the naming convention for this relation);
35+
is the main relation, the naming convention is used for this relation);
3636

3737
* a Console ``Input`` has many arguments and many options. There is no "main"
3838
relation, and so the naming convention does not apply.
@@ -72,7 +72,7 @@ must be used instead (where ``XXX`` is the name of the related thing):
7272

7373
.. note::
7474

75-
While "setXXX" and "replaceXXX" are very similar, there is one notable
76-
difference: "setXXX" may replace, or add new elements to the relation.
75+
While "setXXX" and "replaceXXX" are very similar, there is one notable
76+
difference: "setXXX" may replace, or add new elements to the relation.
7777
"replaceXXX", on the other hand, cannot add new elements. If an unrecognized
7878
key as passed to "replaceXXX" it must throw an exception.

contributing/code/patches.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Set up your user information with your real name and a working email address:
2929
3030
.. tip::
3131

32-
If you are new to Git, we highly recommend you to read the excellent and
32+
If you are new to Git, you are highly recommended to read the excellent and
3333
free `ProGit`_ book.
3434

3535
.. tip::

contributing/documentation/overview.rst

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ then clone your fork:
2626
$ git clone git://github.com/YOURUSERNAME/symfony-docs.git
2727
2828
Consistent with Symfony's source code, the documentation repository is split into
29-
three branches: ``2.0`` for the current Symfony 2.0.x release, ``2.1`` for the
30-
current Symfony 2.1.x release and ``master`` as the development branch for
29+
three branches: ``2.0`` for the current Symfony 2.0.x release, ``2.1`` for the
30+
current Symfony 2.1.x release and ``master`` as the development branch for
3131
upcoming releases.
3232

3333
Unless you're documenting a feature that's new to Symfony 2.1, your changes
34-
should always be based on the 2.0 branch instead of the master branch. To do
34+
should always be based on the 2.0 branch instead of the master branch. To do
3535
this checkout the 2.0 branch before the next step:
3636

3737
.. code-block:: bash
@@ -52,7 +52,7 @@ the ``symfony-docs`` ``master`` branch.
5252
.. image:: /images/docs-pull-request.png
5353
:align: center
5454

55-
If you have made your changes based on the 2.0 branch then you need to change
55+
If you have made your changes based on the 2.0 branch then you need to change
5656
the base branch to be 2.0 on the preview page:
5757

5858
.. image:: /images/docs-pull-request-change-base.png
@@ -61,7 +61,7 @@ the base branch to be 2.0 on the preview page:
6161
.. note::
6262

6363
All changes made to the 2.0 branch will be merged into 2.1 which in turn will be
64-
merged into the master branch for the next release on a weekly basis.
64+
merged into the master branch for the next release on a weekly basis.
6565

6666
GitHub covers the topic of `pull requests`_ in detail.
6767

@@ -73,9 +73,9 @@ GitHub covers the topic of `pull requests`_ in detail.
7373
.. tip::
7474

7575
Please be patient. It can take from 15 minutes to several days for your changes
76-
to appear on the symfony.com website after the documentation team merges your
77-
pull request. You can check if your changes have introduced some markup issues
78-
by going to the `Documentation Build Errors`_ page (it is updated each French
76+
to appear on the symfony.com website after the documentation team merges your
77+
pull request. You can check if your changes have introduced some markup issues
78+
by going to the `Documentation Build Errors`_ page (it is updated each French
7979
night at 3AM when the server rebuilds the documentation).
8080

8181
Standards
@@ -88,19 +88,19 @@ look and feel familiar, you should follow these rules:
8888
as well as the `Twig Coding Standards`_;
8989
* Each line should break approximately after the first word that crosses the
9090
72nd character (so most lines end up being 72-78 lines);
91-
* When we fold one or more lines of code, we place ``...`` in a comment at the point
91+
* When you fold one or more lines of code, place ``...`` in a comment at the point
9292
of the fold. These comments are: ``// ...`` (php), ``# ...`` (yaml/bash), ``{# ... #}``
9393
(twig), ``<!-- ... -->`` (xml/html), ``; ...`` (ini), ``...`` (text);
94-
* When we fold a part of a line, e.g. a variable value, we put ``...`` (without comment)
94+
* When you fold a part of a line, e.g. a variable value, put ``...`` (without comment)
9595
at the place of the fold;
9696
* Description of the folded code: (optional)
97-
If we fold several lines: the description of the fold can be placed after the ``...``
98-
If we fold only part of a line: the description can be placed before the line;
97+
If you fold several lines: the description of the fold can be placed after the ``...``
98+
If you fold only part of a line: the description can be placed before the line;
9999
* If useful, a ``codeblock`` should begin with a comment containing the filename
100100
of the file in the code block. Don't place a blank line after this comment,
101101
unless the next line is also a comment;
102102
* You should put a ``$`` in front of every bash line;
103-
* We prefer the ``::`` shorthand over ``.. code-block:: php`` to begin a PHP
103+
* The ``::`` shorthand is preferred over ``.. code-block:: php`` to begin a PHP
104104
code block.
105105

106106
An example::

cookbook/console/console_command.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ To make the console commands available automatically with Symfony2, create a
1515
``Command`` directory inside your bundle and create a php file suffixed with
1616
``Command.php`` for each command that you want to provide. For example, if you
1717
want to extend the ``AcmeDemoBundle`` (available in the Symfony Standard
18-
Edition) to greet us from the command line, create ``GreetCommand.php`` and
18+
Edition) to greet you from the command line, create ``GreetCommand.php`` and
1919
add the following to it::
2020

2121
// src/Acme/DemoBundle/Command/GreetCommand.php
@@ -93,9 +93,9 @@ should be used instead of :class:`Symfony\\Component\\Console\\Application`::
9393
Getting Services from the Service Container
9494
-------------------------------------------
9595

96-
By using :class:`Symfony\\Bundle\\FrameworkBundle\\Command\\ContainerAwareCommand`
97-
as the base class for the command (instead of the more basic
98-
:class:`Symfony\\Component\\Console\\Command\\Command`), you have access to the
96+
By using :class:`Symfony\\Bundle\\FrameworkBundle\\Command\\ContainerAwareCommand`
97+
as the base class for the command (instead of the more basic
98+
:class:`Symfony\\Component\\Console\\Command\\Command`), you have access to the
9999
service container. In other words, you have access to any configured service.
100100
For example, you could easily extend the task to be translatable::
101101

cookbook/event_dispatcher/before_after_filters.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ your listener to be called just before any controller is executed.
180180
With this configuration, your ``TokenListener`` ``onKernelController`` method
181181
will be executed on each request. If the controller that is about to be executed
182182
implements ``TokenAuthenticatedController``, token authentication is
183-
applied. This lets us have a "before" filter on any controller that you
183+
applied. This lets you have a "before" filter on any controller that you
184184
want.
185185

186186
After filters with the ``kernel.response`` Event

cookbook/form/dynamic_form_generation.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ might look like the following::
120120
// During form creation setData() is called with null as an argument
121121
// by the FormBuilder constructor. You're only concerned with when
122122
// setData is called with an actual Entity object in it (whether new
123-
// or fetched with Doctrine). This if statement lets us skip right
123+
// or fetched with Doctrine). This if statement lets you skip right
124124
// over the null condition.
125125
if (null === $data) {
126126
return;

cookbook/service_container/event_listener.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ component and can be viewed in the :class:`Symfony\\Component\\HttpKernel\\Kerne
1111
To hook into an event and add your own custom logic, you have to create
1212
a service that will act as an event listener on that event. In this entry,
1313
you will create a service that will act as an Exception Listener, allowing
14-
us to modify how exceptions are shown by our application. The ``KernelEvents::EXCEPTION``
14+
you to modify how exceptions are shown by our application. The ``KernelEvents::EXCEPTION``
1515
event is just one of the core kernel events::
1616

1717
// src/Acme/DemoBundle/Listener/AcmeExceptionListener.php

quick_tour/the_architecture.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ a single ``Bundle`` class that describes it::
147147
return $bundles;
148148
}
149149

150-
In addition to the ``AcmeDemoBundle`` that we have already talked about, notice
150+
In addition to the ``AcmeDemoBundle`` that was already talked about, notice
151151
that the kernel also enables other bundles such as the ``FrameworkBundle``,
152152
``DoctrineBundle``, ``SwiftmailerBundle``, and ``AsseticBundle`` bundle.
153153
They are all part of the core framework.
@@ -297,8 +297,8 @@ If you follow these conventions, then you can use :doc:`bundle inheritance</cook
297297
to "override" files, controllers or templates. For example, you can create
298298
a bundle - ``AcmeNewBundle`` - and specify that it overrides ``AcmeDemoBundle``.
299299
When Symfony loads the ``AcmeDemoBundle:Welcome:index`` controller, it will
300-
first look for the ``WelcomeController`` class in ``AcmeNewBundle`` and, if
301-
it doesn't exist, then look inside ``AcmeDemoBundle``. This means that one bundle
300+
first look for the ``WelcomeController`` class in ``AcmeNewBundle`` and, if
301+
it doesn't exist, then look inside ``AcmeDemoBundle``. This means that one bundle
302302
can override almost any part of another bundle!
303303

304304
Do you understand now why Symfony2 is so flexible? Share your bundles between

quick_tour/the_big_picture.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ First, check that you have installed and configured a Web server (such as
2020
Apache) with PHP 5.3.2 or higher.
2121

2222
.. tip::
23-
23+
2424
If you have PHP 5.4, you could use the built-in web server. The built-in
2525
server should be used only for development purpose, but it can help you
2626
to start your project quickly and easily.
2727

2828
Just use this command to launch the server:
29-
29+
3030
.. code-block:: bash
3131
3232
$ php -S localhost:80 -t /path/to/www
@@ -223,7 +223,7 @@ the ``Acme\DemoBundle\Controller\WelcomeController`` class::
223223

224224
.. tip::
225225

226-
You could have used the full class and method name -
226+
You could have used the full class and method name -
227227
``Acme\DemoBundle\Controller\WelcomeController::indexAction`` - for the
228228
``_controller`` value. But if you follow some simple conventions, the
229229
logical name is shorter and allows for more flexibility.
@@ -347,12 +347,12 @@ templates work in Symfony2.
347347
Bundles
348348
~~~~~~~
349349

350-
You might have wondered why the :term:`bundle` word is used in many names we
350+
You might have wondered why the :term:`bundle` word is used in many names you
351351
have seen so far. All the code you write for your application is organized in
352352
bundles. In Symfony2 speak, a bundle is a structured set of files (PHP files,
353353
stylesheets, JavaScripts, images, ...) that implements a single feature (a
354354
blog, a forum, ...) and which can be easily shared with other developers. As
355-
of now, we have manipulated one bundle, ``AcmeDemoBundle``. You will learn
355+
of now, you have manipulated one bundle, ``AcmeDemoBundle``. You will learn
356356
more about bundles in the last chapter of this tutorial.
357357

358358
.. _quick-tour-big-picture-environments:

0 commit comments

Comments
 (0)