Remove scott and hard-coded passwords for test users (oracle-samples#109)

nigelbayliss · web-flow · commit d85d39dfc7f3 · 2020-06-18T11:10:45.000-07:00
* security update

* security update

* security update
diff --git a/optimizer/faster_stats/README.md b/optimizer/faster_stats/README.md
@@ -1,10 +1,13 @@
 
 
-First, create a user called STEST by adapting the the user.sql script to use an appropriate tablespace (which needs to have about 1.5GB free).
+First, create a user called STEST.
+
+EDIT user.sql script to use an appropriate tablespace and password (which needs to have about 1.5GB free).
+EDIT cusr.sql to set the password/connect string 
 
 Two 'connect' scripts are available:
 cadm.sql      <-- Connects to SYSDBA account
-cusr.sql      <-- Connects to the STEST user account
+cusr.sql      <-- Connects to the STEST user account - EDIT THIS TO SET YOUR PASSWORD
 You can edit these to suit you system, particularly if you are using a multitenant environment.
 
 Create tables: 
diff --git a/optimizer/faster_stats/cusr.sql b/optimizer/faster_stats/cusr.sql
@@ -1 +1 @@
-connect stest/stest
+connect stest/<put_your_password_here>
diff --git a/optimizer/faster_stats/user.sql b/optimizer/faster_stats/user.sql
@@ -1,4 +1,4 @@
-create user stest identified by stest;
+create user stest identified by <put_your_password_here>;
 grant dba to stest;
 grant sysdba to stest;
 alter user stest default tablespace big;
diff --git a/optimizer/spm_plan_control/README.md b/optimizer/spm_plan_control/README.md
@@ -1,5 +1,11 @@
 <h2>Using SQL Plan Management to Control SQL Execution Plans</h2>
 
+Note that some scripts will DROP AND CREATE a new user called SPM_TESTU.
+
+EDIT the following scripts to set the SPM_TESTU password and connect strings:
+
+- example.sql, example2.sql, connect_user.sql ./SE/example_outln.sql ./SE/example_se.sql ./SE/connect_user.sql
+
 Based on <a href="https://blogs.oracle.com/optimizer/using-sql-plan-management-to-control-sql-execution-plans">this blog article.</a>
 
 The example.sql script demonstrates how to control SQL execution plans using SQL plan management. 
@@ -12,8 +18,6 @@ Scripts create utility procedures called "set_my_plan" and "add_my_plan" (see pr
 
 Example output is shown in example.lst and example2.lst. 
 
-Note that example.sql example2.sql scripts will DROP AND CREATE a new user called SPM_TESTU.
-
 Scripts tested in Oracle Database 11g Release 2, Oracle Database 12c Release 2 and Oracle Database 18c. The only caveat is that in Oracle Database 11g DBMS_XPLAN sometimes returns ORA-01403, but the example still works.
 
 Now included: SPM example for Oracle Database 18c Standard Edition (see SE directory)
diff --git a/optimizer/spm_plan_control/SE/connect_user.sql b/optimizer/spm_plan_control/SE/connect_user.sql
@@ -1,2 +1,3 @@
-connect spm_testu/spm_testu
+--##### EDIT HERE TO SET PASSWORD/CONNECT STRING #####
+connect spm_testu/<your_password_here>
 
diff --git a/optimizer/spm_plan_control/SE/example_outln.sql b/optimizer/spm_plan_control/SE/example_outln.sql
@@ -8,7 +8,8 @@ set echo on
 pause p...
 drop user spm_testu cascade;
 
-create user spm_testu identified by spm_testu;
+--##### EDIT HERE TO SET PASSWORD #####
+create user spm_testu identified by <your_password_here>;
 grant connect,resource to spm_testu;
 grant unlimited tablespace to spm_testu;
 grant select on v_$sqlarea to spm_testu;
diff --git a/optimizer/spm_plan_control/SE/example_se.sql b/optimizer/spm_plan_control/SE/example_se.sql
@@ -8,7 +8,8 @@ set echo on
 pause p...
 drop user spm_testu cascade;
 
-create user spm_testu identified by spm_testu;
+--##### EDIT HERE TO SET PASSWORD #####
+create user spm_testu identified by <your_password_here>;
 grant connect,resource to spm_testu;
 grant unlimited tablespace to spm_testu;
 grant select on v_$sqlarea to spm_testu;
diff --git a/optimizer/spm_plan_control/connect_user.sql b/optimizer/spm_plan_control/connect_user.sql
@@ -1,2 +1,3 @@
-connect spm_testu/spm_testu
+--##### EDIT HERE TO SET PASSWORD/CONNECT STRING #####
+connect spm_testu/<your_password_here>
 
diff --git a/optimizer/spm_plan_control/example.sql b/optimizer/spm_plan_control/example.sql
@@ -8,7 +8,8 @@ set echo on
 pause p...
 drop user spm_testu cascade;
 
-create user spm_testu identified by spm_testu;
+--##### EDIT HERE TO SET PASSWORD #####
+create user spm_testu identified by <your_password_here>;
 grant connect,resource to spm_testu;
 grant unlimited tablespace to spm_testu;
 grant select on v_$sqlarea to spm_testu;
diff --git a/optimizer/spm_plan_control/example2.sql b/optimizer/spm_plan_control/example2.sql
@@ -8,7 +8,8 @@ set echo on
 pause p...
 drop user spm_testu cascade;
 
-create user spm_testu identified by spm_testu;
+--##### EDIT HERE TO SET PASSWORD #####
+create user spm_testu identified by <your_password_here>;
 grant connect,resource to spm_testu;
 grant unlimited tablespace to spm_testu;
 grant select on v_$sqlarea to spm_testu;
diff --git a/optimizer/topn/eg1.sql b/optimizer/topn/eg1.sql
@@ -1,5 +1,3 @@
-connect scott/tiger
-
 SELECT deptno, job, APPROX_SUM(sal),
        APPROX_RANK(partition by deptno ORDER BY APPROX_SUM(sal) desc) rk
 FROM   emp
diff --git a/optimizer/topn/eg2.sql b/optimizer/topn/eg2.sql
@@ -1,5 +1,3 @@
-connect scott/tiger 
-
 SELECT deptno, job, APPROX_SUM(sal), APPROX_COUNT(*)
 FROM   emp
 GROUP BY deptno, job
diff --git a/optimizer/topn/eg3.sql b/optimizer/topn/eg3.sql
@@ -1,5 +1,3 @@
-connect scott/tiger
-
 SELECT deptno, job, APPROX_SUM(sal) sum_sal,
        APPROX_SUM(sal,'MAX_ERROR') sum_sal_err
 FROM   emp

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-connect stest/stest`
	`1`	`+connect stest/<put_your_password_here>`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`		`-connect spm_testu/spm_testu`
	`1`	`+--##### EDIT HERE TO SET PASSWORD/CONNECT STRING #####`
	`2`	`+connect spm_testu/<your_password_here>`
`2`	`3`