Improve error handling on failed DNode::connect()

igorw · igorw · commit 5a98fbb84d99 · 2013-02-05T15:06:42.000+01:00
diff --git a/src/DNode/DNode.php b/src/DNode/DNode.php
@@ -38,7 +38,7 @@ public function connect()
             throw new \Exception("For now we only support TCP connections to a defined port");
         }
 
-        $client = stream_socket_client("tcp://{$params['host']}:{$params['port']}");
+        $client = @stream_socket_client("tcp://{$params['host']}:{$params['port']}");
         if (!$client) {
             $e = new \RuntimeException("No connection to DNode server in tcp://{$params['host']}:{$params['port']}");
             $this->emit('error', array($e));
@@ -47,9 +47,6 @@ public function connect()
                 trigger_error((string) $e, E_USER_ERROR);
             }
 
-            var_dump('sleeping');
-            sleep(1);
-
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function connect()`
`38`	`38`	`throw new \Exception("For now we only support TCP connections to a defined port");`
`39`	`39`	`}`
`40`	`40`
`41`		`- $client = stream_socket_client("tcp://{$params['host']}:{$params['port']}");`
	`41`	`+ $client = @stream_socket_client("tcp://{$params['host']}:{$params['port']}");`
`42`	`42`	`if (!$client) {`
`43`	`43`	`$e = new \RuntimeException("No connection to DNode server in tcp://{$params['host']}:{$params['port']}");`
`44`	`44`	`$this->emit('error', array($e));`
`@@ -47,9 +47,6 @@ public function connect()`
`47`	`47`	`trigger_error((string) $e, E_USER_ERROR);`
`48`	`48`	`}`
`49`	`49`
`50`		`- var_dump('sleeping');`
`51`		`- sleep(1);`
`52`		`-`
`53`	`50`	`return;`
`54`	`51`	`}`
`55`	`52`