Add tests for Protocol

igorw · igorw · commit ea50577654c0 · 2012-11-01T23:54:48.000+01:00
diff --git a/src/DNode/Protocol.php b/src/DNode/Protocol.php
@@ -1,5 +1,6 @@
 <?php
 namespace DNode;
+use React\Socket\ServerInterface;
 
 class Protocol
 {
@@ -70,7 +71,7 @@ public function parseArgs($args) {
                 continue;
             }
 
-            throw new \Exception("Not sure what to do about " . gettype($arg) . " arguments");
+            throw new \InvalidArgumentException("Not sure what to do about " . gettype($arg) . " arguments");
         }
 
         return $params;
diff --git a/tests/DNode/FunctionalTest.php b/tests/DNode/FunctionalTest.php
@@ -5,6 +5,7 @@
 class FunctionalTest extends \PHPUnit_Framework_TestCase
 {
     /**
+     * @covers DNode\DNode::__construct
      * @covers DNode\DNode::connect
      * @covers DNode\DNode::listen
      * @test
diff --git a/tests/DNode/ProtocolTest.php b/tests/DNode/ProtocolTest.php
@@ -0,0 +1,112 @@
+<?php
+namespace DNode;
+
+class ProtocolTest extends TestCase
+{
+    public function setUp()
+    {
+        $this->protocol = new Protocol(new Dog());
+    }
+
+    /**
+     * @test
+     * @covers DNode\Protocol::__construct
+     * @covers DNode\Protocol::create
+     */
+    public function createShouldReturnSession()
+    {
+        $session = $this->protocol->create();
+        $this->assertInstanceOf('DNode\Session', $session);
+    }
+
+    /**
+     * @test
+     * @covers DNode\Protocol::destroy
+     */
+    public function destroyShouldUnsetSession()
+    {
+        $session = $this->protocol->create();
+        $this->protocol->destroy($session->id);
+    }
+
+    /**
+     * @test
+     * @covers DNode\Protocol::end
+     */
+    public function endShouldCallEndOnAllSessions()
+    {
+        $sessions = array(
+            $this->protocol->create(),
+            $this->protocol->create(),
+        );
+
+        foreach ($sessions as $session) {
+            $session->on('end', $this->expectCallableOnce());
+        }
+
+        $this->protocol->end();
+    }
+
+    /**
+     * @test
+     * @covers DNode\Protocol::parseArgs
+     * @dataProvider provideParseArgs
+     */
+    public function parseArgsShouldParseArgsCorrectly($expected, $args)
+    {
+        $this->assertSame($expected, $this->protocol->parseArgs($args));
+    }
+
+    public function provideParseArgs()
+    {
+        $closure = function () {};
+        $server = new ServerStub();
+
+        $obj = new \stdClass();
+        $obj->foo = 'bar';
+        $obj->baz = 'qux';
+
+        return array(
+            'string number becomes port' => array(
+                array('port' => '8080'),
+                array('8080'),
+            ),
+            'leading / becomes path' => array(
+                array('path' => '/foo'),
+                array('/foo'),
+            ),
+            'string becomes host' => array(
+                array('host' => 'foo'),
+                array('foo'),
+            ),
+            'integer becomes port' => array(
+                array('port' => 8080),
+                array(8080),
+            ),
+            'Closure becomes block' => array(
+                array('block' => $closure),
+                array($closure),
+            ),
+            'ServerInterface becomes server' => array(
+                array('server' => $server),
+                array($server),
+            ),
+            'random object becomes key => val' => array(
+                array('foo' => 'bar', 'baz' => 'qux'),
+                array($obj),
+            ),
+        );
+    }
+
+    /**
+     * @test
+     * @covers DNode\Protocol::parseArgs
+     * @expectedException InvalidArgumentException
+     * @expectedExceptionMessage Not sure what to do about array arguments
+     */
+    public function parseArgsShouldRejectInvalidArgs()
+    {
+        $args = array(array('wat'));
+        $this->protocol->parseArgs($args);
+    }
+}
diff --git a/tests/DNode/ServerStub.php b/tests/DNode/ServerStub.php
@@ -0,0 +1,19 @@
+<?php
+namespace DNode;
+use Evenement\EventEmitter;
+use React\Socket\ServerInterface;
+
+class ServerStub extends EventEmitter implements ServerInterface
+{
+    public function listen($port, $host = '127.0.0.1')
+    {
+    }
+
+    public function getPort()
+    {
+    }
+
+    public function shutdown()
+    {
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`<?php`
`2`	`2`	`namespace DNode;`
	`3`	`+use React\Socket\ServerInterface;`
`3`	`4`
`4`	`5`	`class Protocol`
`5`	`6`	`{`
`@@ -70,7 +71,7 @@ public function parseArgs($args) {`
`70`	`71`	`continue;`
`71`	`72`	`}`
`72`	`73`
`73`		`- throw new \Exception("Not sure what to do about " . gettype($arg) . " arguments");`
	`74`	`+ throw new \InvalidArgumentException("Not sure what to do about " . gettype($arg) . " arguments");`
`74`	`75`	`}`
`75`	`76`
`76`	`77`	`return $params;`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`class FunctionalTest extends \PHPUnit_Framework_TestCase`
`6`	`6`	`{`
`7`	`7`	`/**`
	`8`	`+ * @covers DNode\DNode::__construct`
`8`	`9`	`* @covers DNode\DNode::connect`
`9`	`10`	`* @covers DNode\DNode::listen`
`10`	`11`	`* @test`