Remove incorrect swapping code from diffseq()

andreas-gruenbacher · andreas-gruenbacher · commit c61a2a40ddbd · 2014-03-30T12:41:27.000+02:00
Here, m and n are accessed before being initialized, and so a and b are never
swapped.  Swapping a and b for computing a diff is correct (but useless) for
computing the Longest Common Subsequence, but incorrect for computing diffs, so
remove this code.
diff --git a/json-diff.js b/json-diff.js
@@ -89,12 +89,6 @@ var json_diff = (function() {
 	  row = [], c = [],
 	  left, diag, latch;
 
-      //make sure shorter sequence is the column sequence
-      if (m < n) {
-	var swap = a;
-	a = b;
-	b = swap;
-      }
       m = a.length;
       n = b.length;
 
