Merge pull request scala#2888 from xeno-by/topic/typed-annotated

retronym · retronym · commit d46519da657a · 2013-09-04T07:14:27.000-07:00
typedAnnotated no longer emits nulls
diff --git a/src/compiler/scala/tools/nsc/typechecker/Typers.scala b/src/compiler/scala/tools/nsc/typechecker/Typers.scala
@@ -4107,7 +4107,7 @@ trait Typers extends Modes with Adaptations with Tags {
           // we need symbol-ful originals for reification
           // hence we go the extra mile to hand-craft tis guy
           val original = arg1 match {
-            case tt @ TypeTree() => Annotated(ann, tt.original)
+            case tt @ TypeTree() if tt.original != null => Annotated(ann, tt.original)
             // this clause is needed to correctly compile stuff like "new C @D" or "@(inline @getter)"
             case _ => Annotated(ann, arg1)
           }
diff --git a/test/files/run/typed-annotated.check b/test/files/run/typed-annotated.check
@@ -0,0 +1 @@
+42
diff --git a/test/files/run/typed-annotated/Macros_1.scala b/test/files/run/typed-annotated/Macros_1.scala
@@ -0,0 +1,17 @@
+import scala.reflect.macros.Context
+import language.experimental.macros
+
+class ann extends scala.annotation.StaticAnnotation
+
+object Macros {
+  def impl(c: Context) = {
+    import c.universe._
+    // val tpt = Annotated(Apply(Select(New(Ident(newTypeName("ann"))), nme.CONSTRUCTOR), List()), Ident(newTypeName("Int")))
+    val tpt = Annotated(Apply(Select(New(Ident(newTypeName("ann"))), nme.CONSTRUCTOR), List()), TypeTree(weakTypeOf[Int]))
+    c.Expr[Unit](Block(
+      List(ValDef(Modifiers(), newTermName("x"), tpt, Literal(Constant(42)))),
+      Apply(Ident(newTermName("println")), List(Ident(newTermName("x"))))))
+  }
+
+  def foo = macro impl
+}
diff --git a/test/files/run/typed-annotated/Test_2.scala b/test/files/run/typed-annotated/Test_2.scala
@@ -0,0 +1,3 @@
+object Test extends App {
+  Macros.foo
+}

Original file line number	Diff line number	Diff line change
`@@ -4107,7 +4107,7 @@ trait Typers extends Modes with Adaptations with Tags {`
`4107`	`4107`	`// we need symbol-ful originals for reification`
`4108`	`4108`	`// hence we go the extra mile to hand-craft tis guy`
`4109`	`4109`	`val original = arg1 match {`
`4110`		`- case tt @ TypeTree() => Annotated(ann, tt.original)`
	`4110`	`+ case tt @ TypeTree() if tt.original != null => Annotated(ann, tt.original)`
`4111`	`4111`	`// this clause is needed to correctly compile stuff like "new C @D" or "@(inline @getter)"`
`4112`	`4112`	`case _ => Annotated(ann, arg1)`
`4113`	`4113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+object Test extends App {`
	`2`	`+ Macros.foo`
	`3`	`+}`