chore: style improvements for conformance tests (GoogleCloudPlatform#74)

bshaffer · web-flow · commit 59176ba9a4cf · 2021-03-09T10:13:56.000-08:00
diff --git a/.github/workflows/conformance.yml b/.github/workflows/conformance.yml
@@ -13,6 +13,7 @@ jobs:
     strategy:
       matrix:
         php-version: [7.2, 7.3, 7.4]
+    name: PHP ${{ matrix.php-version }} Conformance Test
     steps:
     - name: Checkout code
       uses: actions/checkout@v2
diff --git a/.github/workflows/unit.yaml b/.github/workflows/unit.yaml
@@ -11,7 +11,7 @@ jobs:
       matrix:
         operating-system: [ubuntu-latest]
         php-versions: ['7.2', '7.3', '7.4']
-    name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
+    name: PHP ${{ matrix.php-versions }} Unit Test
     steps:
     - name: Checkout
       uses: actions/checkout@v2
diff --git a/src/CloudEvent.php b/src/CloudEvent.php
@@ -18,7 +18,9 @@
 
 namespace Google\CloudFunctions;
 
-class CloudEvent implements \JsonSerializable
+use JsonSerializable;
+
+class CloudEvent implements JsonSerializable
 {
     // Required Fields
     private $id;
diff --git a/tests/CloudEventTest.php b/tests/CloudEventTest.php
@@ -29,22 +29,22 @@ class CloudEventTest extends TestCase
     public function testJsonSerialize()
     {
         $event = new CloudEvent(
-          '1413058901901494',
-          '//pubsub.googleapis.com/projects/MY-PROJECT/topics/MY-TOPIC',
-          '1.0',
-          'com.google.cloud.pubsub.topic.publish',
-          'application/json',
-          'type.googleapis.com/google.logging.v2.LogEntry',
-          'My Subject',
-          '2020-12-08T20:03:19.162Z',
-          [
-              "message" => [
-                  "data" => "SGVsbG8gdGhlcmU=",
-                  "messageId" => "1408577928008405",
-                  "publishTime" => "2020-08-06T22:31:14.536Z"
-              ],
-              "subscription" => "projects/MY-PROJECT/subscriptions/MY-SUB"
-          ]
+            '1413058901901494',
+            '//pubsub.googleapis.com/projects/MY-PROJECT/topics/MY-TOPIC',
+            '1.0',
+            'com.google.cloud.pubsub.topic.publish',
+            'application/json',
+            'type.googleapis.com/google.logging.v2.LogEntry',
+            'My Subject',
+            '2020-12-08T20:03:19.162Z',
+            [
+                "message" => [
+                    "data" => "SGVsbG8gdGhlcmU=",
+                    "messageId" => "1408577928008405",
+                    "publishTime" => "2020-08-06T22:31:14.536Z"
+                ],
+                "subscription" => "projects/MY-PROJECT/subscriptions/MY-SUB"
+            ]
         );
 
         $want = '{

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,9 @@`
`18`	`18`
`19`	`19`	`namespace Google\CloudFunctions;`
`20`	`20`
`21`		`-class CloudEvent implements \JsonSerializable`
	`21`	`+use JsonSerializable;`
	`22`	`+`
	`23`	`+class CloudEvent implements JsonSerializable`
`22`	`24`	`{`
`23`	`25`	`// Required Fields`
`24`	`26`	`private $id;`