allow datetime as an argument to CloudEvent

bshaffer · bshaffer · commit 9cf00154381b · 2021-03-18T16:21:11.000-07:00
diff --git a/src/CloudEvent.php b/src/CloudEvent.php
@@ -47,7 +47,7 @@ public function __construct(
         ?string $datacontenttype,
         ?string $dataschema,
         ?string $subject,
-        ?string $time,
+        $time,
         $data
     ) {
         $this->id = $id;
@@ -154,10 +154,16 @@ public function __toString()
         return $output;
     }
 
-    private static function timeAsDateTime(?string $time): ?DateTime
+    private static function timeAsDateTime($time): ?DateTime
     {
-        if (is_null($time)) {
-            return null;
+        if ($time instanceof DateTime || is_null($time)) {
+            return $time;
+        }
+
+        if (!is_string($time)) {
+            throw new \UnexpectedValueException(
+                'time must be a string, DateTime, or null'
+            );
         }
 
         return new DateTime($time);
diff --git a/tests/CloudEventTest.php b/tests/CloudEventTest.php
@@ -68,4 +68,40 @@ public function testJsonSerialize()
 
         $this->assertEquals(json_encode($event, JSON_PRETTY_PRINT), $want);
     }
+
+    public function testTimeCanBeDateTime()
+    {
+        $time = new \DateTime();
+        $event = new CloudEvent(
+            '1413058901901494',
+            '//pubsub.googleapis.com/projects/MY-PROJECT/topics/MY-TOPIC',
+            '1.0',
+            'com.google.cloud.pubsub.topic.publish',
+            'application/json',
+            'type.googleapis.com/google.logging.v2.LogEntry',
+            'My Subject',
+            $time, // can be a datetime
+            null
+        );
+
+        $this->assertEquals($time, $event->getTime());
+    }
+
+    public function testInvalidTime()
+    {
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage('time must be a string, DateTime, or null');
+
+        $event = new CloudEvent(
+            '1413058901901494',
+            '//pubsub.googleapis.com/projects/MY-PROJECT/topics/MY-TOPIC',
+            '1.0',
+            'com.google.cloud.pubsub.topic.publish',
+            'application/json',
+            'type.googleapis.com/google.logging.v2.LogEntry',
+            'My Subject',
+            123456, // not a string, datetime, or null
+            null
+        );
+    }
 }
