Skip to content

Commit 3ccdf5b

Browse files
Russell Kingbroonie
authored andcommitted
ASoC: kirkwood-i2s: more pause-mode fixes
Don't even momentarily set the pause status when starting the channel; if we do, we should check the busy bit to ensure that we comply with the spec. In any case, it isn't necessary; we will not active on a START event so there is no need to pause the DMA. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
1 parent 982b604 commit 3ccdf5b

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

sound/soc/kirkwood/kirkwood-i2s.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,6 @@ static int kirkwood_i2s_play_trigger(struct snd_pcm_substream *substream,
205205

206206
switch (cmd) {
207207
case SNDRV_PCM_TRIGGER_START:
208-
/* stop audio, enable interrupts */
209-
ctl |= KIRKWOOD_PLAYCTL_PAUSE;
210-
writel(ctl, priv->io + KIRKWOOD_PLAYCTL);
211-
212208
value = readl(priv->io + KIRKWOOD_INT_MASK);
213209
value |= KIRKWOOD_INT_CAUSE_PLAY_BYTES;
214210
writel(value, priv->io + KIRKWOOD_INT_MASK);
@@ -269,11 +265,6 @@ static int kirkwood_i2s_rec_trigger(struct snd_pcm_substream *substream,
269265

270266
switch (cmd) {
271267
case SNDRV_PCM_TRIGGER_START:
272-
/* stop audio, enable interrupts */
273-
value = readl(priv->io + KIRKWOOD_RECCTL);
274-
value |= KIRKWOOD_RECCTL_PAUSE;
275-
writel(value, priv->io + KIRKWOOD_RECCTL);
276-
277268
value = readl(priv->io + KIRKWOOD_INT_MASK);
278269
value |= KIRKWOOD_INT_CAUSE_REC_BYTES;
279270
writel(value, priv->io + KIRKWOOD_INT_MASK);

0 commit comments

Comments
 (0)