net: sctp: sctp_auth_key_put: use kzfree instead of kfree

Daniel Borkmann · davem330 · commit 586c31f3bf04 · 2013-02-07T23:43:42.000-05:00
For sensitive data like keying material, it is common practice to zero
out keys before returning the memory back to the allocator. Thus, use
kzfree instead of kfree.

Signed-off-by: Daniel Borkmann &lt;dborkman@redhat.com&gt;
Acked-by: Neil Horman &lt;nhorman@tuxdriver.com&gt;
Acked-by: Vlad Yasevich &lt;vyasevich@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/sctp/auth.c b/net/sctp/auth.c
@@ -71,7 +71,7 @@ void sctp_auth_key_put(struct sctp_auth_bytes *key)
 		return;
 
 	if (atomic_dec_and_test(&key->refcnt)) {
-		kfree(key);
+		kzfree(key);
 		SCTP_DBG_OBJCNT_DEC(keys);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ void sctp_auth_key_put(struct sctp_auth_bytes *key)`
`71`	`71`	`return;`
`72`	`72`
`73`	`73`	`if (atomic_dec_and_test(&key->refcnt)) {`
`74`		`- kfree(key);`
	`74`	`+ kzfree(key);`
`75`	`75`	`SCTP_DBG_OBJCNT_DEC(keys);`
`76`	`76`	`}`
`77`	`77`	`}`