powerpc/eeh: Do not invalidate PE properly

shangw · ozbenh · commit e716e0143846 · 2012-11-26T09:14:16.000+11:00
While the EEH does recovery on the specific PE that has PCI errors,
the PCI devices belonging to the PE will be removed and the PE will
be marked as invalid since we still need the information stored in
the PE. We only invalidate the PE when it doesn't have associated
EEH devices and valid child PEs. However, the code used to check
that is wrong. The patch fixes that.

Signed-off-by: Gavin Shan &lt;shangw@linux.vnet.ibm.com&gt;
Signed-off-by: Benjamin Herrenschmidt &lt;benh@kernel.crashing.org&gt;
diff --git a/arch/powerpc/platforms/pseries/eeh_pe.c b/arch/powerpc/platforms/pseries/eeh_pe.c
@@ -449,7 +449,7 @@ int eeh_rmv_from_parent_pe(struct eeh_dev *edev, int purge_pe)
 			if (list_empty(&pe->edevs)) {
 				cnt = 0;
 				list_for_each_entry(child, &pe->child_list, child) {
-					if (!(pe->type & EEH_PE_INVALID)) {
+					if (!(child->type & EEH_PE_INVALID)) {
 						cnt++;
 						break;
 					}

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,7 @@ int eeh_rmv_from_parent_pe(struct eeh_dev *edev, int purge_pe)`
`449`	`449`	`if (list_empty(&pe->edevs)) {`
`450`	`450`	`cnt = 0;`
`451`	`451`	`list_for_each_entry(child, &pe->child_list, child) {`
`452`		`- if (!(pe->type & EEH_PE_INVALID)) {`
	`452`	`+ if (!(child->type & EEH_PE_INVALID)) {`
`453`	`453`	`cnt++;`
`454`	`454`	`break;`
`455`	`455`	`}`