arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON

JuliaLawall · tmlind · commit f64d204b5cf2 · 2012-12-17T10:50:41.000-08:00
Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
@@ -485,8 +485,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
 		if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
 			freqsel = _omap3_dpll_compute_freqsel(clk,
 						dd->last_rounded_n);
-			if (!freqsel)
-				WARN_ON(1);
+			WARN_ON(!freqsel);
 		}
 
 		pr_debug("%s: %s: set rate: locking rate to %lu.\n",

Original file line number	Diff line number	Diff line change
`@@ -485,8 +485,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,`
`485`	`485`	`if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {`
`486`	`486`	`freqsel = _omap3_dpll_compute_freqsel(clk,`
`487`	`487`	`dd->last_rounded_n);`
`488`		`- if (!freqsel)`
`489`		`- WARN_ON(1);`
	`488`	`+ WARN_ON(!freqsel);`
`490`	`489`	`}`
`491`	`490`
`492`	`491`	`pr_debug("%s: %s: set rate: locking rate to %lu.\n",`