Skip to content

Commit fa416dd

Browse files
lynxeye-devairlied
authored andcommitted
drm: tegra: remove redundant tegra2_tmds_config entry
The 720p and 1080p entries are completely redundant, as we are matching the table entries against <=pclk. Also generalize the comment, as we are using those table entries even when driving other modes than the standard TV ones. Signed-off-by: Lucas Stach <dev@lynxeye.de> Signed-off-by: Dave Airlie <airlied@redhat.com>
1 parent 83c0bcb commit fa416dd

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

drivers/gpu/drm/tegra/hdmi.c

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ struct tmds_config {
149149
};
150150

151151
static const struct tmds_config tegra2_tmds_config[] = {
152-
{ /* 480p modes */
152+
{ /* slow pixel clock modes */
153153
.pclk = 27000000,
154154
.pll0 = SOR_PLL_BG_V17_S(3) | SOR_PLL_ICHPMP(1) |
155155
SOR_PLL_RESISTORSEL | SOR_PLL_VCOCAP(0) |
@@ -163,21 +163,8 @@ static const struct tmds_config tegra2_tmds_config[] = {
163163
DRIVE_CURRENT_LANE1(DRIVE_CURRENT_7_125_mA) |
164164
DRIVE_CURRENT_LANE2(DRIVE_CURRENT_7_125_mA) |
165165
DRIVE_CURRENT_LANE3(DRIVE_CURRENT_7_125_mA),
166-
}, { /* 720p modes */
167-
.pclk = 74250000,
168-
.pll0 = SOR_PLL_BG_V17_S(3) | SOR_PLL_ICHPMP(1) |
169-
SOR_PLL_RESISTORSEL | SOR_PLL_VCOCAP(1) |
170-
SOR_PLL_TX_REG_LOAD(3),
171-
.pll1 = SOR_PLL_TMDS_TERM_ENABLE | SOR_PLL_PE_EN,
172-
.pe_current = PE_CURRENT0(PE_CURRENT_6_0_mA) |
173-
PE_CURRENT1(PE_CURRENT_6_0_mA) |
174-
PE_CURRENT2(PE_CURRENT_6_0_mA) |
175-
PE_CURRENT3(PE_CURRENT_6_0_mA),
176-
.drive_current = DRIVE_CURRENT_LANE0(DRIVE_CURRENT_7_125_mA) |
177-
DRIVE_CURRENT_LANE1(DRIVE_CURRENT_7_125_mA) |
178-
DRIVE_CURRENT_LANE2(DRIVE_CURRENT_7_125_mA) |
179-
DRIVE_CURRENT_LANE3(DRIVE_CURRENT_7_125_mA),
180-
}, { /* 1080p modes */
166+
},
167+
{ /* high pixel clock modes */
181168
.pclk = UINT_MAX,
182169
.pll0 = SOR_PLL_BG_V17_S(3) | SOR_PLL_ICHPMP(1) |
183170
SOR_PLL_RESISTORSEL | SOR_PLL_VCOCAP(1) |

0 commit comments

Comments
 (0)