Add isPhone method, fixes jenssegers#41

jenssegers · jenssegers · commit 6b9a79a7838a · 2015-10-16T18:14:37.000+02:00
diff --git a/README.md b/README.md
@@ -129,12 +129,20 @@ $browser = $agent->browser();
 
 ### Desktop detection
 
-Check if the user is a desktop.
+Check if the user is using a desktop device.
 
 ```php
 $agent->isDesktop();
 ```
 
+### Phone detection
+
+Check if the user is using a phone device.
+
+```php
+$agent->isPhone();
+```
+
 *This checks if a user is not a mobile device, tablet or robot.*
 
 ### Robot detection
diff --git a/src/Agent.php b/src/Agent.php
@@ -224,6 +224,18 @@ public function isDesktop($userAgent = null, $httpHeaders = null)
         return (! $this->isMobile() && ! $this->isTablet() && ! $this->isRobot());
     }
 
+    /**
+     * Check if the device is a mobile phone.
+     *
+     * @param  string $userAgent   deprecated
+     * @param  array  $httpHeaders deprecated
+     * @return bool
+     */
+    public function isPhone($userAgent = null, $httpHeaders = null)
+    {
+        return ($this->isMobile() && ! $this->isTablet());
+    }
+
     /**
      * Get the robot name.
      *
diff --git a/tests/AgentTest.php b/tests/AgentTest.php
@@ -177,18 +177,21 @@ public function testDesktop()
         {
             $agent->setUserAgent($ua);
             $this->assertTrue($agent->isDesktop(), $ua);
+            $this->assertFalse($agent->isMobile(), $ua);
         }
 
         foreach($this->robots as $ua => $robot)
         {
             $agent->setUserAgent($ua);
             $this->assertFalse($agent->isDesktop(), $ua);
+            $this->assertFalse($agent->isMobile(), $ua);
         }
 
         foreach($this->devices as $ua => $device)
         {
             $agent->setUserAgent($ua);
             $this->assertFalse($agent->isDesktop(), $ua);
+            $this->assertTrue($agent->isMobile(), $ua);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -177,18 +177,21 @@ public function testDesktop()`
`177`	`177`	`{`
`178`	`178`	`$agent->setUserAgent($ua);`
`179`	`179`	`$this->assertTrue($agent->isDesktop(), $ua);`
	`180`	`+ $this->assertFalse($agent->isMobile(), $ua);`
`180`	`181`	`}`
`181`	`182`
`182`	`183`	`foreach($this->robots as $ua => $robot)`
`183`	`184`	`{`
`184`	`185`	`$agent->setUserAgent($ua);`
`185`	`186`	`$this->assertFalse($agent->isDesktop(), $ua);`
	`187`	`+ $this->assertFalse($agent->isMobile(), $ua);`
`186`	`188`	`}`
`187`	`189`
`188`	`190`	`foreach($this->devices as $ua => $device)`
`189`	`191`	`{`
`190`	`192`	`$agent->setUserAgent($ua);`
`191`	`193`	`$this->assertFalse($agent->isDesktop(), $ua);`
	`194`	`+ $this->assertTrue($agent->isMobile(), $ua);`
`192`	`195`	`}`
`193`	`196`	`}`
`194`	`197`