Merge pull request barryvdh#410 from sebdesign/patch-1

barryvdh · barryvdh · commit 3cc1de3b6c1b · 2015-10-26T10:10:50.000+01:00
Type-hint appropriate arguments
diff --git a/src/LaravelDebugbar.php b/src/LaravelDebugbar.php
@@ -456,7 +456,7 @@ public function getJavascriptRenderer($baseUrl = null, $basePath = null)
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @return \Symfony\Component\HttpFoundation\Response
      */
-    public function modifyResponse($request, $response)
+    public function modifyResponse(Request $request, Response $response)
     {
         $app = $this->app;
         if ($app->runningInConsole() || !$this->isEnabled() || $this->isDebugbarRequest()) {
@@ -593,7 +593,7 @@ protected function isDebugbarRequest()
      * @param  \Symfony\Component\HttpFoundation\Request $request
      * @return bool
      */
-    protected function isJsonRequest($request)
+    protected function isJsonRequest(Request $request)
     {
         // If XmlHttpRequest, return true
         if ($request->isXmlHttpRequest()) {
@@ -841,7 +841,7 @@ protected function selectStorage(DebugBar $debugbar)
         }
     }
 
-    protected function addClockworkHeaders($response)
+    protected function addClockworkHeaders(Response $response)
     {
         $prefix = $this->app['config']->get('debugbar.route_prefix');
         $response->headers->set('X-Clockwork-Id', $this->getCurrentRequestId(), true);

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ public function getJavascriptRenderer($baseUrl = null, $basePath = null)`
`456`	`456`	`* @param \Symfony\Component\HttpFoundation\Response $response`
`457`	`457`	`* @return \Symfony\Component\HttpFoundation\Response`
`458`	`458`	`*/`
`459`		`- public function modifyResponse($request, $response)`
	`459`	`+ public function modifyResponse(Request $request, Response $response)`
`460`	`460`	`{`
`461`	`461`	`$app = $this->app;`
`462`	`462`	`if ($app->runningInConsole() \|\| !$this->isEnabled() \|\| $this->isDebugbarRequest()) {`
`@@ -593,7 +593,7 @@ protected function isDebugbarRequest()`
`593`	`593`	`* @param \Symfony\Component\HttpFoundation\Request $request`
`594`	`594`	`* @return bool`
`595`	`595`	`*/`
`596`		`- protected function isJsonRequest($request)`
	`596`	`+ protected function isJsonRequest(Request $request)`
`597`	`597`	`{`
`598`	`598`	`// If XmlHttpRequest, return true`
`599`	`599`	`if ($request->isXmlHttpRequest()) {`
`@@ -841,7 +841,7 @@ protected function selectStorage(DebugBar $debugbar)`
`841`	`841`	`}`
`842`	`842`	`}`
`843`	`843`
`844`		`- protected function addClockworkHeaders($response)`
	`844`	`+ protected function addClockworkHeaders(Response $response)`
`845`	`845`	`{`
`846`	`846`	`$prefix = $this->app['config']->get('debugbar.route_prefix');`
`847`	`847`	`$response->headers->set('X-Clockwork-Id', $this->getCurrentRequestId(), true);`