Last details

pedrovgs · pedrovgs · commit 2d321c00e39b · 2014-07-03T00:17:38.000+02:00
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ Sample project created to reinforce some of the main concepts described in the t
 
 In this repository you are going to find som interesting samples like:
 
-* **MVP** and **MVVM** samples.
+* **MVP** and **MVVM (whitout data binding engine)** samples.
 * How to use **fragments**.
 * How to use **Dagger to implement dependency injection**.
 * Use **resource qualifiers** to change the layout used in **different screen sizes**.
@@ -14,7 +14,7 @@ In this repository you are going to find som interesting samples like:
 * How to use **styles and themes**.
 * How to **communicate fragments** in the same activity.
 * **Butterknife** library usage to **avoid UI duplicated code**.
-* Correct **naming** for Android resources.
+* Uniform **naming** for Android resources.
 * How to use **Navigator** or **ActionCommands** to **implement the navigation** inside the application.
 * Use resource custom qualifiers to **split resource files by domain**.
 * Different **layout usage**: RelativeLayout, LinearLayout, FrameLayout.
diff --git a/app/src/main/java/com/github/pedrovgs/effectiveandroidui/ui/fragment/TvShowCatalogFragment.java b/app/src/main/java/com/github/pedrovgs/effectiveandroidui/ui/fragment/TvShowCatalogFragment.java
@@ -119,7 +119,7 @@ public class TvShowCatalogFragment extends BaseFragment implements TvShowCatalog
     refreshAdapter();
   }
 
-  @Override public void updateTitleWithCountOfVideow(final int counter) {
+  @Override public void updateTitleWithCountOfTvShows(final int counter) {
     String actionBarTitle = getString(R.string.app_name_with_chapter_counter, counter);
     getActivity().setTitle(actionBarTitle);
   }
@@ -137,11 +137,11 @@ public class TvShowCatalogFragment extends BaseFragment implements TvShowCatalog
     getActivity().setTitle(R.string.app_name);
   }
 
-  @Override public void showTvShowInfo(TvShow tvShow) {
-    ToastUtils.showError(tvShow.getTitle(), getActivity());
+  @Override public void showTvShowTitleAsMessage(TvShow tvShow) {
+    ToastUtils.showShortMessage(tvShow.getTitle(), getActivity());
   }
 
-  @Override public void showTvShow(final TvShow tvShow) {
+  @Override public void openTvShow(final TvShow tvShow) {
     if (listener != null) {
       listener.onTvShowClicked(tvShow);
     }
diff --git a/app/src/main/java/com/github/pedrovgs/effectiveandroidui/ui/presenter/TvShowCatalogPresenter.java b/app/src/main/java/com/github/pedrovgs/effectiveandroidui/ui/presenter/TvShowCatalogPresenter.java
@@ -80,11 +80,11 @@ public void loadCatalog(final TvShowCollection tvShowCollection) {
   }
 
   public void onTvShowThumbnailClicked(final TvShow tvShow) {
-    view.showTvShow(tvShow);
+    view.openTvShow(tvShow);
   }
 
   public void onTvShowClicked(final TvShow tvShow) {
-    view.showTvShowInfo(tvShow);
+    view.showTvShowTitleAsMessage(tvShow);
   }
 
   public TvShowCollection getCurrentTvShows() {
@@ -125,7 +125,7 @@ private void showTvShows(Collection<TvShow> tvShows) {
     if (view.isReady()) {
       view.renderVideos(tvShows);
       view.hideLoading();
-      view.updateTitleWithCountOfVideow(tvShows.size());
+      view.updateTitleWithCountOfTvShows(tvShows.size());
     }
   }
 
@@ -136,7 +136,8 @@ private void checkViewAlreadySetted() {
   }
 
   /**
-   * View interface created to abstract the view implementation used in this presenter.
+   * View interface created to abstract the view
+   * implementation used in this presenter.
    */
   public interface View {
 
@@ -146,17 +147,17 @@ public interface View {
 
     void renderVideos(final Collection<TvShow> tvShows);
 
-    void updateTitleWithCountOfVideow(final int counter);
+    void updateTitleWithCountOfTvShows(final int counter);
 
     void showConnectionErrorMessage();
 
     void showEmptyCase();
 
     void showDefaultTitle();
 
-    void showTvShowInfo(TvShow tvShow);
+    void showTvShowTitleAsMessage(TvShow tvShow);
 
-    void showTvShow(TvShow tvShow);
+    void openTvShow(TvShow tvShow);
 
     boolean isReady();
 

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public class TvShowCatalogFragment extends BaseFragment implements TvShowCatalog`
`119`	`119`	`refreshAdapter();`
`120`	`120`	`}`
`121`	`121`
`122`		`- @Override public void updateTitleWithCountOfVideow(final int counter) {`
	`122`	`+ @Override public void updateTitleWithCountOfTvShows(final int counter) {`
`123`	`123`	`String actionBarTitle = getString(R.string.app_name_with_chapter_counter, counter);`
`124`	`124`	`getActivity().setTitle(actionBarTitle);`
`125`	`125`	`}`
`@@ -137,11 +137,11 @@ public class TvShowCatalogFragment extends BaseFragment implements TvShowCatalog`
`137`	`137`	`getActivity().setTitle(R.string.app_name);`
`138`	`138`	`}`
`139`	`139`
`140`		`- @Override public void showTvShowInfo(TvShow tvShow) {`
`141`		`- ToastUtils.showError(tvShow.getTitle(), getActivity());`
	`140`	`+ @Override public void showTvShowTitleAsMessage(TvShow tvShow) {`
	`141`	`+ ToastUtils.showShortMessage(tvShow.getTitle(), getActivity());`
`142`	`142`	`}`
`143`	`143`
`144`		`- @Override public void showTvShow(final TvShow tvShow) {`
	`144`	`+ @Override public void openTvShow(final TvShow tvShow) {`
`145`	`145`	`if (listener != null) {`
`146`	`146`	`listener.onTvShowClicked(tvShow);`
`147`	`147`	`}`