Skip to content

Commit 493ea44

Browse files
Small refactoring
1 parent 532c098 commit 493ea44

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

shedlock-core/src/main/java/net/javacrumbs/shedlock/core/DefaultLockManager.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,22 @@ public void executeIfNotLocked(Runnable task) {
4444
logger.debug("No lock configuration for {}. Executing without lock.", task);
4545
task.run();
4646
} else {
47-
LockConfiguration lockConfig = lockConfigOptional.get();
48-
Optional<SimpleLock> lock = lockProvider.lock(lockConfig);
49-
if (lock.isPresent()) {
50-
try {
51-
logger.debug("Locked {}.", lockConfig.getName());
52-
task.run();
53-
} finally {
54-
lock.get().unlock();
55-
logger.debug("Unlocked {}.", lockConfig.getName());
56-
}
57-
} else {
58-
logger.info("Not executing {}. It's locked.", lockConfig.getName());
47+
executeIfNotLocked(task, lockConfigOptional.get());
48+
}
49+
}
50+
51+
private void executeIfNotLocked(Runnable task, LockConfiguration lockConfig) {
52+
Optional<SimpleLock> lock = lockProvider.lock(lockConfig);
53+
if (lock.isPresent()) {
54+
try {
55+
logger.debug("Locked {}.", lockConfig.getName());
56+
task.run();
57+
} finally {
58+
lock.get().unlock();
59+
logger.debug("Unlocked {}.", lockConfig.getName());
5960
}
61+
} else {
62+
logger.info("Not executing {}. It's locked.", lockConfig.getName());
6063
}
6164
}
6265
}

0 commit comments

Comments
 (0)