minor fix for Spring

nobodyiam · nobodyiam · commit 9b06053cf4e0 · 2017-03-08T22:02:07.000+08:00
1. make ApolloAnnotationProcessor run as late as possible
2. make PropertySourcesProcessor run as early as possible
3. fix PropertySourcesProcessor initialization logic to support multple
Spring contexts
diff --git a/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java b/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
@@ -9,6 +9,8 @@
 
 import org.springframework.beans.BeansException;
 import org.springframework.beans.factory.config.BeanPostProcessor;
+import org.springframework.core.Ordered;
+import org.springframework.core.PriorityOrdered;
 import org.springframework.core.annotation.AnnotationUtils;
 import org.springframework.util.ReflectionUtils;
 
@@ -20,7 +22,7 @@
  *
  * @author Jason Song(song_s@ctrip.com)
  */
-public class ApolloAnnotationProcessor implements BeanPostProcessor {
+public class ApolloAnnotationProcessor implements BeanPostProcessor, PriorityOrdered {
   @Override
   public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
     Class clazz = bean.getClass();
@@ -80,4 +82,9 @@ public void onChange(ConfigChangeEvent changeEvent) {
     }
   }
 
+  @Override
+  public int getOrder() {
+    //make it as late as possible
+    return Ordered.LOWEST_PRECEDENCE;
+  }
 }
diff --git a/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/config/PropertySourcesProcessor.java b/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/config/PropertySourcesProcessor.java
@@ -11,6 +11,8 @@
 import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
 import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
 import org.springframework.context.EnvironmentAware;
+import org.springframework.core.Ordered;
+import org.springframework.core.PriorityOrdered;
 import org.springframework.core.env.CompositePropertySource;
 import org.springframework.core.env.ConfigurableEnvironment;
 import org.springframework.core.env.Environment;
@@ -24,10 +26,9 @@
  *
  * @author Jason Song(song_s@ctrip.com)
  */
-public class PropertySourcesProcessor implements BeanFactoryPostProcessor, EnvironmentAware {
+public class PropertySourcesProcessor implements BeanFactoryPostProcessor, EnvironmentAware, PriorityOrdered {
   private static final String APOLLO_PROPERTY_SOURCE_NAME = "ApolloPropertySources";
   private static final Multimap<Integer, String> NAMESPACE_NAMES = HashMultimap.create();
-  private static final AtomicBoolean PROPERTY_SOURCES_INITIALIZED = new AtomicBoolean(false);
 
   private ConfigurableEnvironment environment;
 
@@ -37,15 +38,14 @@ public static boolean addNamespaces(Collection<String> namespaces, int order) {
 
   @Override
   public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
-    if (!PROPERTY_SOURCES_INITIALIZED.compareAndSet(false, true)) {
-      //already initialized
-      return;
-    }
-
     initializePropertySources();
   }
 
   protected void initializePropertySources() {
+    if (environment.getPropertySources().contains(APOLLO_PROPERTY_SOURCE_NAME)) {
+      //already initialized
+      return;
+    }
     CompositePropertySource composite = new CompositePropertySource(APOLLO_PROPERTY_SOURCE_NAME);
 
     //sort by order asc
@@ -72,6 +72,11 @@ public void setEnvironment(Environment environment) {
   //only for test
    private static void reset() {
     NAMESPACE_NAMES.clear();
-    PROPERTY_SOURCES_INITIALIZED.set(false);
+  }
+
+  @Override
+  public int getOrder() {
+    //make it as early as possible
+    return Ordered.HIGHEST_PRECEDENCE;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,8 @@`
`9`	`9`
`10`	`10`	`import org.springframework.beans.BeansException;`
`11`	`11`	`import org.springframework.beans.factory.config.BeanPostProcessor;`
	`12`	`+import org.springframework.core.Ordered;`
	`13`	`+import org.springframework.core.PriorityOrdered;`
`12`	`14`	`import org.springframework.core.annotation.AnnotationUtils;`
`13`	`15`	`import org.springframework.util.ReflectionUtils;`
`14`	`16`
`@@ -20,7 +22,7 @@`
`20`	`22`	`*`
`21`	`23`	`* @author Jason Song(song_s@ctrip.com)`
`22`	`24`	`*/`
`23`		`-public class ApolloAnnotationProcessor implements BeanPostProcessor {`
	`25`	`+public class ApolloAnnotationProcessor implements BeanPostProcessor, PriorityOrdered {`
`24`	`26`	`@Override`
`25`	`27`	`public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {`
`26`	`28`	`Class clazz = bean.getClass();`
`@@ -80,4 +82,9 @@ public void onChange(ConfigChangeEvent changeEvent) {`
`80`	`82`	`}`
`81`	`83`	`}`
`82`	`84`
	`85`	`+ @Override`
	`86`	`+ public int getOrder() {`
	`87`	`+ //make it as late as possible`
	`88`	`+ return Ordered.LOWEST_PRECEDENCE;`
	`89`	`+ }`
`83`	`90`	`}`