Fixed bug that left a '-1' tabindex on a select after destroying selectize

Scott Hamper · Scott Hamper · commit f09f8da8f8ad · 2013-10-28T17:10:24.000-04:00
Selectize sets a '-1' tabindex on the original select element when
initialized. When the select element did not originally have a tabindex
set, Selectize would not properly remove the '-1' tabindex when
destroying itself.
diff --git a/dist/js/selectize.js b/dist/js/selectize.js
@@ -2192,6 +2192,7 @@
 			self.$input
 				.html('')
 				.append(revertSettings.$children)
+                .removeAttr('tabindex')
 				.attr({tabindex: revertSettings.tabindex})
 				.show();
 	
diff --git a/dist/js/selectize.min.js b/dist/js/selectize.min.js
diff --git a/dist/js/standalone/selectize.js b/dist/js/standalone/selectize.js
@@ -2776,6 +2776,7 @@
 			self.$input
 				.html('')
 				.append(revertSettings.$children)
+                .removeAttr('tabindex')
 				.attr({tabindex: revertSettings.tabindex})
 				.show();
 	
diff --git a/dist/js/standalone/selectize.min.js b/dist/js/standalone/selectize.min.js
diff --git a/src/selectize.js b/src/selectize.js
@@ -1752,6 +1752,7 @@ $.extend(Selectize.prototype, {
 		self.$input
 			.html('')
 			.append(revertSettings.$children)
+            .removeAttr('tabindex')
 			.attr({tabindex: revertSettings.tabindex})
 			.show();
 
diff --git a/test/api.js b/test/api.js
@@ -549,6 +549,11 @@
 				expect(test.$select.html()).to.be.equal(children);
 				expect(test.$select.attr('tabindex')).to.be.equal('9999');
 			});
+			it('should remove tabindex if it was originally undefined', function() {
+				var test = setup_test('<select>', {});
+                test.selectize.destroy();
+                expect(test.$select.attr('tabindex')).to.be.equal(undefined);
+			});
 		});
 
 	});
