* Implemented x-arango-version. Closes arangodb#160.

frankmayer · frankmayer · commit c58cd7faf428 · 2013-11-11T11:58:24.000+02:00
There is a minor backward incompatibility. We are now following ArangoDB's integer version numbering style.
Instead of 1.4.0 we return 10400 when calling the Connection::getVersion() / getClientVersion() method.
This has hopefully not any enormous impact. If it has please inform me so we can find a better solution...
diff --git a/lib/triagens/ArangoDb/Connection.php b/lib/triagens/ArangoDb/Connection.php
@@ -29,7 +29,7 @@ class Connection
      *
      * @var string
      */
-    public static $_apiVersion = '1.4.0';
+    public static $_apiVersion = 10400;
 
     /**
      * Connection options
@@ -425,7 +425,7 @@ public static function getVersion()
      */
     public static function getClientVersion()
     {
-        return self::$_apiVersion;
+         return self::$_apiVersion;
     }
 
 
diff --git a/lib/triagens/ArangoDb/HttpHelper.php b/lib/triagens/ArangoDb/HttpHelper.php
@@ -143,9 +143,12 @@ public static function buildRequest(ConnectionOptions $options, $method, $url, $
             $connection = sprintf("Connection: %s%s", $options[ConnectionOptions::OPTION_CONNECTION], self::EOL);
         }
 
+        $apiVersion = 'x-arango-version: ' . Connection::$_apiVersion . self::EOL;
+
         // finally assemble the request
         $request = sprintf('%s %s %s%s', $method, $url, self::PROTOCOL, self::EOL) .
             $host .
+            $apiVersion .
             $contentType .
             $authorization .
             $connection .
diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -65,10 +65,10 @@ public function testGetApiVersion()
         $connection = getConnection();
 
         $response = $connection->getVersion();
-        $this->assertTrue($response !== "", 'Version String is empty!');
+        $this->assertTrue($response >0, 'Version number is not correct!');
 
         $response = $connection->getClientVersion();
-        $this->assertTrue($response !== "", 'Version String is empty!');
+        $this->assertTrue($response >0, 'Version number is not correct!');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class Connection`
`29`	`29`	`*`
`30`	`30`	`* @var string`
`31`	`31`	`*/`
`32`		`- public static $_apiVersion = '1.4.0';`
	`32`	`+ public static $_apiVersion = 10400;`
`33`	`33`
`34`	`34`	`/**`
`35`	`35`	`* Connection options`
`@@ -425,7 +425,7 @@ public static function getVersion()`
`425`	`425`	`*/`
`426`	`426`	`public static function getClientVersion()`
`427`	`427`	`{`
`428`		`- return self::$_apiVersion;`
	`428`	`+ return self::$_apiVersion;`
`429`	`429`	`}`
`430`	`430`
`431`	`431`