Skip to content

Commit 37ec355

Browse files
r0manbbatsov
r0man
authored and
bbatsov
committed
Fix eastwood lint issues
1 parent 70caf18 commit 37ec355

File tree

9 files changed

+23
-22
lines changed

9 files changed

+23
-22
lines changed

‎eastwood.clj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

‎project.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@
3434
:cljfmt [:test
3535
{:plugins [[lein-cljfmt "0.9.0" :exclusions [org.clojure/clojure
3636
org.clojure/clojurescript]]]}]
37-
:eastwood {:plugins [[jonase/eastwood "1.3.0"]]
37+
:eastwood {:plugins [[jonase/eastwood "1.3.0"]]
3838
:eastwood {;; :implicit-dependencies would fail spuriously when the CI matrix runs for Clojure < 1.10,
3939
;; because :implicit-dependencies can only work for a certain corner case starting from 1.10.
4040
:exclude-linters [:implicit-dependencies]
4141
:exclude-namespaces [refactor-nrepl.plugin]
42-
:add-linters [:performance :boxed-math]
42+
:add-linters [:performance]
4343
:config-files ["eastwood.clj"]}}
4444
:clj-kondo [:test
4545
{:dependencies [[clj-kondo "2022.10.14"]]}]

‎test/haystack/stacktrace/parser/aviso_test.clj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
(is (= 'clojure.lang.ExceptionInfo type)))))
3737
(testing ":trace"
3838
(doseq [element trace]
39-
(is (test/stacktrace-element? element) element))
39+
(is (test/stacktrace-element? element) (pr-str element)))
4040
(testing "first frame"
4141
(is (= '[haystack.parser.throwable-test eval12321 "REPL Input"] (first trace))))
4242
(testing "last frame"
@@ -72,7 +72,7 @@
7272
(is (= 'clojure.lang.ExceptionInfo type)))))
7373
(testing ":trace"
7474
(doseq [element trace]
75-
(is (test/stacktrace-element? element) element))
75+
(is (test/stacktrace-element? element) (pr-str element)))
7676
(testing "first frame"
7777
(is (= '[clojure.lang.AFn applyToHelper "AFn.java" 156] (first trace))))
7878
(testing "last frame"
@@ -96,7 +96,7 @@
9696
(is (= 'java.lang.ArithmeticException type)))))
9797
(testing ":trace"
9898
(doseq [element trace]
99-
(is (test/stacktrace-element? element) element))
99+
(is (test/stacktrace-element? element) (pr-str element)))
100100
(testing "first frame"
101101
(is (= '[haystack.parser.throwable-test fn "throwable_test.clj" 13]
102102
(first trace))))
@@ -122,7 +122,7 @@
122122
(is (= 'clojure.lang.ExceptionInfo type)))))
123123
(testing ":trace"
124124
(doseq [element trace]
125-
(is (test/stacktrace-element? element) element))
125+
(is (test/stacktrace-element? element) (pr-str element)))
126126
(testing "first frame"
127127
(is (= '[java.lang.Thread run "Thread.java" 829] (first trace))))
128128
(testing "last frame"

‎test/haystack/stacktrace/parser/clojure/repl_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
(take 3 trace))))))
4949
(testing ":trace"
5050
(doseq [element trace]
51-
(is (test/stacktrace-element? element) element))
51+
(is (test/stacktrace-element? element) (pr-str element)))
5252
(testing "first frame"
5353
(is (= '[clojure.lang.Compiler$InvokeExpr eval "Compiler.java" 3706] (first trace))))
5454
(testing "last frame"
@@ -72,7 +72,7 @@
7272
(is (= 'ArithmeticException type)))))
7373
(testing ":trace"
7474
(doseq [element trace]
75-
(is (test/stacktrace-element? element) element))
75+
(is (test/stacktrace-element? element) (pr-str element)))
7676
(testing "first frame"
7777
(is (= '[clojure.lang.Numbers divide "Numbers.java" 188] (first trace))))
7878
(testing "last frame"
@@ -96,7 +96,7 @@
9696
(is (= 'ExceptionInfo type)))))
9797
(testing ":trace"
9898
(doseq [element trace]
99-
(is (test/stacktrace-element? element) element))
99+
(is (test/stacktrace-element? element) (pr-str element)))
100100
(testing "first frame"
101101
(is (= '[java.lang.Thread run "Thread.java" 829] (first trace))))
102102
(testing "last frame"

‎test/haystack/stacktrace/parser/clojure/stacktrace_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
(take 3 trace))))))
4949
(testing ":trace"
5050
(doseq [element trace]
51-
(is (test/stacktrace-element? element) element))
51+
(is (test/stacktrace-element? element) (pr-str element)))
5252
(testing "first frame"
5353
(is (= '[clojure.lang.AFn applyToHelper "AFn.java" 156]
5454
(first trace))))
@@ -74,7 +74,7 @@
7474
(is (= 'java.lang.ArithmeticException type)))))
7575
(testing ":trace"
7676
(doseq [element trace]
77-
(is (test/stacktrace-element? element) element))
77+
(is (test/stacktrace-element? element) (pr-str element)))
7878
(testing "first frame"
7979
(is (= '[clojure.lang.Numbers divide "Numbers.java" 188] (first trace))))
8080
(testing "last frame"
@@ -98,7 +98,7 @@
9898
(is (= 'clojure.lang.ExceptionInfo type)))))
9999
(testing ":trace"
100100
(doseq [element trace]
101-
(is (test/stacktrace-element? element) element))
101+
(is (test/stacktrace-element? element) (pr-str element)))
102102
(testing "first frame"
103103
(is (= '[java.lang.Thread run "Thread.java" 829] (first trace))))
104104
(testing "last frame"

‎test/haystack/stacktrace/parser/clojure/tagged_literal_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
(is (= 'clojure.lang.ExceptionInfo type)))))
3737
(testing ":trace"
3838
(doseq [element trace]
39-
(is (test/stacktrace-element? element) element))
39+
(is (test/stacktrace-element? element) (pr-str element)))
4040
(testing "first frame"
4141
(is (= '[clojure.lang.AFn applyToHelper "AFn.java" 156] (first trace))))
4242
(testing "last frame"
@@ -60,7 +60,7 @@
6060
(is (= 'java.lang.ArithmeticException type)))))
6161
(testing ":trace"
6262
(doseq [element trace]
63-
(is (test/stacktrace-element? element) element))
63+
(is (test/stacktrace-element? element) (pr-str element)))
6464
(testing "first frame"
6565
(is (= '[clojure.lang.Numbers divide "Numbers.java" 188] (first trace))))
6666
(testing "last frame"
@@ -84,7 +84,7 @@
8484
(is (= 'clojure.lang.ExceptionInfo type)))))
8585
(testing ":trace"
8686
(doseq [element trace]
87-
(is (test/stacktrace-element? element) element))
87+
(is (test/stacktrace-element? element) (pr-str element)))
8888
(testing "first frame"
8989
(is (= '[java.lang.Thread run "Thread.java" 829] (first trace))))
9090
(testing "last frame"

‎test/haystack/stacktrace/parser/clojure/throwable_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
(is (= 'clojure.lang.ExceptionInfo type)))))
4848
(testing ":trace"
4949
(doseq [element trace]
50-
(is (test/stacktrace-element? element) element)))))
50+
(is (test/stacktrace-element? element) (pr-str element))))))
5151

5252
(deftest parse-stacktrace-divide-by-zero-test
5353
(let [{:keys [cause data trace stacktrace-type via]} (parser/parse-stacktrace divide-by-zero)]
@@ -67,7 +67,7 @@
6767
(is (= 'java.lang.ArithmeticException type)))))
6868
(testing ":trace"
6969
(doseq [element trace]
70-
(is (test/stacktrace-element? element) element)))))
70+
(is (test/stacktrace-element? element) (pr-str element))))))
7171

7272
(deftest parse-stacktrace-short-test
7373
(let [{:keys [cause data trace stacktrace-type via]} (parser/parse-stacktrace short-boom)]
@@ -87,7 +87,7 @@
8787
(is (= 'clojure.lang.ExceptionInfo type)))))
8888
(testing ":trace"
8989
(doseq [element trace]
90-
(is (test/stacktrace-element? element) element)))))
90+
(is (test/stacktrace-element? element) (pr-str element))))))
9191

9292
(deftest parse-stacktrace-error-test
9393
(testing "parsing a string not matching the grammar"

‎test/haystack/stacktrace/parser/java_test.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
(take 3 trace))))))
4949
(testing ":trace"
5050
(doseq [element trace]
51-
(is (test/stacktrace-element? element) element))
51+
(is (test/stacktrace-element? element) (pr-str element)))
5252
(testing "first frame"
5353
(is (= '[clojure.lang.AFn applyToHelper "AFn.java" 156]
5454
(first trace))))
@@ -74,7 +74,7 @@
7474
(is (= 'java.lang.ArithmeticException type)))))
7575
(testing ":trace"
7676
(doseq [element trace]
77-
(is (test/stacktrace-element? element) element))
77+
(is (test/stacktrace-element? element) (pr-str element)))
7878
(testing "first frame"
7979
(is (= '[clojure.lang.Numbers divide "Numbers.java" 188] (first trace))))
8080
(testing "last frame"
@@ -98,7 +98,7 @@
9898
(is (= 'clojure.lang.ExceptionInfo type)))))
9999
(testing ":trace"
100100
(doseq [element trace]
101-
(is (test/stacktrace-element? element) element))
101+
(is (test/stacktrace-element? element) (pr-str element)))
102102
(testing "first frame"
103103
(is (= '[java.base/java.lang.Thread run "Thread.java" 829] (first trace))))
104104
(testing "last frame"

‎test/haystack/stacktrace/parser_test.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
(is (string? cause)))
1616
(testing "should parse the trace"
1717
(doseq [element trace]
18-
(is (test/stacktrace-element? element) element)))))))
18+
(is (test/stacktrace-element? element) (pr-str element))))))))
1919

2020
(deftest parse-garbage-test
2121
(doseq [fixture test/fixtures]

0 commit comments

Comments
 (0)