Make :compile-like a string instead

vemv · vemv · commit 84103a0968c5 · 2023-09-29T22:47:39.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## master (unreleased)
 
-## 0.3.0 (2023-09-29)
+## 0.3.1 (2023-09-29)
 
 * `analyzer`: include a `:compile-like` key which indicates if the error happened at a "compile-like" phase.
   * It represents exceptions that happen at runtime (and therefore never include a `:phase`) which however, represent code that cannot possibly work, and therefore are a "compile-like" exception (i.e. a linter could have caught them).
diff --git a/Makefile b/Makefile
@@ -30,7 +30,7 @@ kondo:
 deploy: check-env
 	lein with-profile -user,-dev,+$(VERSION) deploy clojars
 
-# Usage: PROJECT_VERSION=0.3.0 make install
+# Usage: PROJECT_VERSION=0.3.1 make install
 # PROJECT_VERSION is needed because it's not computed dynamically.
 install: check-install-env
 	lein with-profile -user,-dev,+$(VERSION) install
diff --git a/README.org b/README.org
@@ -252,7 +252,7 @@ for writing Instaparse grammars:
 Here's how to deploy to Clojars:
 
 #+begin_src sh
-git tag -a v0.3.0 -m "0.3.0"
+git tag -a v0.3.1 -m "0.3.1"
 git push --tags
 #+end_src
 
diff --git a/src/haystack/analyzer.clj b/src/haystack/analyzer.clj
@@ -368,8 +368,8 @@
         phase (-> cause-data :data :clojure.error/phase)
         m {:class (name (:type cause-data))
            :phase phase
-           :compile-like (boolean (and (not phase)
-                                       (compile-like-exception? cause-data)))
+           :compile-like (pr-str (boolean (and (not phase)
+                                               (compile-like-exception? cause-data))))
            :message (:message cause-data)
            :stacktrace (analyze-stacktrace-data
                         (cond (seq (:trace cause-data))
diff --git a/test/haystack/analyzer_test.clj b/test/haystack/analyzer_test.clj
@@ -614,36 +614,36 @@
 
   (testing "`:compile-like`"
     (testing "For non-existing fields"
-      (is (= [true]
+      (is (= ["true"]
              (->> (try
                     (eval '(.-foo ""))
                     (catch Throwable e
                       (sut/analyze e)))
                   (map :compile-like)))))
     (testing "For non-existing methods"
-      (is (= [true]
+      (is (= ["true"]
              (->> (try
                     (eval '(-> "" (.foo 1 2)))
                     (catch Throwable e
                       (sut/analyze e)))
                   (map :compile-like)))))
     (testing "For vanilla exceptions"
-      (is (= [false]
+      (is (= ["false"]
              (->> (try
                     (throw (ex-info "." {}))
                     (catch Throwable e
                       (sut/analyze e)))
                   (map :compile-like)))))
     (testing "For vanilla `IllegalArgumentException`s"
-      (is (= [false]
+      (is (= ["false"]
              (->> (try
                     (throw (IllegalArgumentException. "foo"))
                     (catch Throwable e
                       (sut/analyze e)))
                   (map :compile-like)))))
     (testing "For exceptions with a `:phase`"
-      (is (#{[false false] ;; normal expectation
-             [false]} ;; clojure 1.8
+      (is (#{["false" "false"] ;; normal expectation
+             ["false"]} ;; clojure 1.8
            (->> (try
                   (eval '(let [1]))
                   (catch Throwable e
