DragControls: Ensure hoveroff is fired correctly. (mrdoob#21376)

tb2k · web-flow · commit 4e204db854dd · 2021-03-02T17:26:24.000Z
* added a condition to catch the case where a hovered object doesn't get hoveredoff before a different object is hoveredon. * DragControls fix for issue mrdoob#21375
diff --git a/examples/js/controls/DragControls.js b/examples/js/controls/DragControls.js
@@ -105,6 +105,15 @@ THREE.DragControls = function ( _objects, _camera, _domElement ) {
 
 			_plane.setFromNormalAndCoplanarPoint( _camera.getWorldDirection( _plane.normal ), _worldPosition.setFromMatrixPosition( object.matrixWorld ) );
 
+			if ( _hovered !== object && _hovered !== null) {
+
+				scope.dispatchEvent( { type: 'hoveroff', object: _hovered } );
+
+				_domElement.style.cursor = 'auto';
+				_hovered = null;
+
+			}
+			
 			if ( _hovered !== object ) {
 
 				scope.dispatchEvent( { type: 'hoveron', object: object } );
diff --git a/examples/jsm/controls/DragControls.js b/examples/jsm/controls/DragControls.js
@@ -114,6 +114,15 @@ var DragControls = function ( _objects, _camera, _domElement ) {
 
 			_plane.setFromNormalAndCoplanarPoint( _camera.getWorldDirection( _plane.normal ), _worldPosition.setFromMatrixPosition( object.matrixWorld ) );
 
+			if ( _hovered !== object && _hovered !== null) {
+
+				scope.dispatchEvent( { type: 'hoveroff', object: _hovered } );
+
+				_domElement.style.cursor = 'auto';
+				_hovered = null;
+
+			}
+			
 			if ( _hovered !== object ) {
 
 				scope.dispatchEvent( { type: 'hoveron', object: object } );
