Skip to content

Commit 116ee4b

Browse files
shaharyar123shaharyar123
authored
refactor: Made react native dependencies optional (optimizely#735)
## Summary Made the following dependencies optional in `datafile-manager` and `event-processor` packages. `@react-native-community/async-storage` `@react-native-community/netinfo` ## Test Plan - Manually tested thoroughly - All tests pass
1 parent 8affc03 commit 116ee4b

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

‎packages/datafile-manager/package-lock.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/datafile-manager/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@optimizely/js-sdk-utils": "^0.4.0",
5353
"decompress-response": "^4.2.1"
5454
},
55-
"peerDependencies": {
55+
"optionalDependencies": {
5656
"@react-native-async-storage/async-storage": "^1.2.0"
5757
},
5858
"scripts": {

‎packages/event-processor/package-lock.json

Lines changed: 9 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/event-processor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"ts-jest": "^23.10.5",
5252
"typescript": "^4.0.3"
5353
},
54-
"peerDependencies": {
54+
"optionalDependencies": {
5555
"@react-native-community/netinfo": "5.9.4",
5656
"@react-native-async-storage/async-storage": "^1.2.0"
5757
}

0 commit comments

Comments
 (0)