Updated versions of murmurhash and uuid and dropped support for old node versions and browsers (optimizely#762)

shaharyar123 · web-flow · commit e6f9a9b89e06 · 2022-07-12T10:52:47.000-07:00
## Summary

- Updated `murmurhash` dependency to version `2.0.1`.
- Updated `uuid` dependency to version `8.3.2`.
- Dropped support of Node JS versions `11` and earlier.
- Dropped support for the following browser versions.
  - All versions of Microsoft Internet Explorer.
  - Chrome versions earlier than `102.0`.
  - Microsoft Edge versions earlier than `84.0`.
  - Firefox versions earlier than `91.0`.
  - Opera versions earlier than `76.0`.
  - Safari versions earlier than `13.0`.

## Test Plan
All existing tests pass.
diff --git a/.github/workflows/javascript.yml b/.github/workflows/javascript.yml
@@ -27,13 +27,13 @@ jobs:
         npm run lint
 
   integration_tests:
-    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@uzair/test-with-fsc
+    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
     secrets:
       CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
       TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
 
   fullstack_production_suite:
-    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@uzair/test-with-fsc
+    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
     with:
       FULLSTACK_TEST_REPO: ProdTesting
     secrets:
@@ -53,7 +53,7 @@ jobs:
     - name: Set up Node
       uses: actions/setup-node@v3
       with:
-        node-version: 8
+        node-version: 12
         cache: 'npm'
         cache-dependency-path: packages/optimizely-sdk/package-lock.json
     - name: Cross-browser and umd unit tests
@@ -66,7 +66,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '8', '9', '10', '12', '14' ]
+        node: [ '12', '14', '16', '18' ]
     steps:
     - uses: actions/checkout@v3
     - name: Set up Node ${{ matrix.node }}
diff --git a/packages/optimizely-sdk/CHANGELOG.md b/packages/optimizely-sdk/CHANGELOG.md
@@ -7,7 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-- Nothing yet!
+### Changed
+- Updated `murmurhash` dependency to version `2.0.1`.
+- Updated `uuid` dependency to version `8.3.2`.
+- Dropped support for the following browser versions.
+  - All versions of Microsof Internet Explorer.
+  - Chrome versions earlier than `102.0`.
+  - Microsoft Edge versions earlier than `84.0`.
+  - Firefox versions earlier than `91.0`.
+  - Opera versions earlier than `76.0`.
+  - Safari versions earlier than `13.0`.
 
 ## [4.9.2] - June 27, 2022
 
diff --git a/packages/optimizely-sdk/karma.base.conf.js b/packages/optimizely-sdk/karma.base.conf.js
@@ -1,5 +1,5 @@
 /**
- * Copyright 2018, 2020 Optimizely
+ * Copyright 2018, 2020, 2022 Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -54,52 +54,50 @@ module.exports = {
   customLaunchers: {
     bs_chrome_mac: {
       base: 'BrowserStack',
-      browser: 'chrome',
-      browser_version: '21.0',
       os: 'OS X',
-      os_version: 'Mountain Lion',
+      os_version: 'Mojave',
+      browserName: 'Chrome',
+      browser_version: '102.0',
+      browser: 'Chrome',
     },
     bs_edge: {
       base: 'BrowserStack',
       os: 'Windows',
       os_version: '10',
-      browser: 'edge',
-      device: null,
-      browser_version: '15.0',
-    },
-    bs_firefox_mac: {
-      base: 'BrowserStack',
-      browser: 'firefox',
-      browser_version: '21.0',
-      os: 'OS X',
-      os_version: 'Mountain Lion',
+      browserName: 'Edge',
+      browser_version: '84.0',
+      browser: 'Edge',
     },
-    bs_ie: {
+    bs_firefox: {
       base: 'BrowserStack',
       os: 'Windows',
-      os_version: '7',
-      browser: 'ie',
-      device: null,
-      browser_version: '10.0',
+      browser: 'Firefox',
+      os_version: '10',
+      browserName: 'Firefox',
+      browser_version: '91.0',
     },
+
     bs_opera_mac: {
       base: 'BrowserStack',
-      browser: 'opera',
-      browser_version: '37',
+      browser: 'Opera',
+      os_version: 'Mojave',
+      browserName: 'Opera',
+      browser: 'Opera',
+      browser_version: '76.0',
       os: 'OS X',
-      os_version: 'Mountain Lion',
     },
     bs_safari: {
       base: 'BrowserStack',
       os: 'OS X',
-      os_version: 'Mountain Lion',
-      browser: 'safari',
+      os_version: 'Catalina',
+      browserName: 'Safari',
+      browser_version: '13.0',
+      browser: 'Safari',
       device: null,
-      browser_version: '6.2',
     },
   },
 
-  browsers: ['bs_chrome_mac', 'bs_edge', 'bs_firefox_mac', 'bs_ie', 'bs_opera_mac', 'bs_safari'],
+  browsers: ['bs_chrome_mac', 'bs_edge', 'bs_firefox', 'bs_opera_mac', 'bs_safari'],
 
   // frameworks to use
   // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
diff --git a/packages/optimizely-sdk/lib/core/bucketer/index.tests.js b/packages/optimizely-sdk/lib/core/bucketer/index.tests.js
@@ -352,10 +352,14 @@ describe('lib/core/bucketer', function () {
         expect(bucketer._generateBucketValue(bucketingKey4)).to.equal(5439);
       });
 
-      it('should return an error if it cannot generate the hash value', function () {
-        assert.throws(function () {
+      it('should return an error if it cannot generate the hash value', function() {
+       const response = assert.throws(function() {
           bucketer._generateBucketValue(null);
-        }, sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read property 'length' of null"));
+        } );
+        expect([
+          sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read property 'length' of null"),  // node v14
+          sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read properties of null (reading \'length\')")  // node v16
+        ]).contain(response.message);
       });
     });
 
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.ts b/packages/optimizely-sdk/lib/utils/fns/index.ts
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import v4 from 'uuid';
+import { v4 } from 'uuid';
 
 const MAX_SAFE_INTEGER_LIMIT = Math.pow(2, 53);
 
diff --git a/packages/optimizely-sdk/package-lock.json b/packages/optimizely-sdk/package-lock.json
diff --git a/packages/optimizely-sdk/package.json b/packages/optimizely-sdk/package.json
