Update Rule Blocklist

pointlessone · dblandin · commit af1fe5ea67ba · 2017-04-11T10:55:36.000-04:00
Remove:

* import/extensions - it does not fail when can not resolve module, uses
  literal value instead
* import/no-absolute-path - does not use module resolution, checks
  whether literal value starts with "/"

Add:

* import/no-restricted-paths - relies on absolutely resolved module
  paths
* node/no-hide-code-modules - relies on module resolution, also
  deprecated
diff --git a/lib/rule_blocklist.js b/lib/rule_blocklist.js
@@ -4,9 +4,9 @@ const Config = require("eslint/lib/config")
   , merge = require("eslint/lib/config/config-ops").merge;
 
 const blocklistedRules = [
+  "import/no-restricted-paths",
   "import/no-unresolved",
-  "import/extensions",
-  "import/no-absolute-path"
+  "node/no-hide-code-modules"
 ];
 
 function filterRules(rules) {
diff --git a/test/rule_blocklist_test.js b/test/rule_blocklist_test.js
@@ -42,16 +42,16 @@ describe("ConfigUpgrader", function() {
     describe("rules", function() {
       [
         [
-          {rules: {"import/no-unresolved": [2, "opt1", "opt2"]}},
-          {rules: {"import/no-unresolved": "off"}}
+          {rules: {"import/no-restricted-paths": 1}},
+          {rules: {"import/no-restricted-paths": "off"}}
         ],
         [
-          {rules: {"import/extensions": 2}},
-          {rules: {"import/extensions": "off"}}
+          {rules: {"import/no-unresolved": [2, "opt1", "opt2"]}},
+          {rules: {"import/no-unresolved": "off"}}
         ],
         [
-          {rules: {"import/no-absolute-path": 1}},
-          {rules: {"import/no-absolute-path": "off"}}
+          {rules: {"node/no-hide-code-modules": 2}},
+          {rules: {"node/no-hide-code-modules": "off"}}
         ]
       ].forEach(function(example){
         let originalConfig = example[0];

Original file line number	Diff line number	Diff line change
`@@ -42,16 +42,16 @@ describe("ConfigUpgrader", function() {`
`42`	`42`	`describe("rules", function() {`
`43`	`43`	`[`
`44`	`44`	`[`
`45`		`- {rules: {"import/no-unresolved": [2, "opt1", "opt2"]}},`
`46`		`- {rules: {"import/no-unresolved": "off"}}`
	`45`	`+ {rules: {"import/no-restricted-paths": 1}},`
	`46`	`+ {rules: {"import/no-restricted-paths": "off"}}`
`47`	`47`	`],`
`48`	`48`	`[`
`49`		`- {rules: {"import/extensions": 2}},`
`50`		`- {rules: {"import/extensions": "off"}}`
	`49`	`+ {rules: {"import/no-unresolved": [2, "opt1", "opt2"]}},`
	`50`	`+ {rules: {"import/no-unresolved": "off"}}`
`51`	`51`	`],`
`52`	`52`	`[`
`53`		`- {rules: {"import/no-absolute-path": 1}},`
`54`		`- {rules: {"import/no-absolute-path": "off"}}`
	`53`	`+ {rules: {"node/no-hide-code-modules": 2}},`
	`54`	`+ {rules: {"node/no-hide-code-modules": "off"}}`
`55`	`55`	`]`
`56`	`56`	`].forEach(function(example){`
`57`	`57`	`let originalConfig = example[0];`