fix(child-directives): prevent loop in case directives compiled as attribute

dimirc · dimirc · commit df8d3cb44ede · 2014-07-14T00:25:40.000-05:00
diff --git a/src/select.js b/src/select.js
@@ -502,12 +502,14 @@
           var transcluded = angular.element('<div>').append(clone);
 
           var transcludedMatch = transcluded.querySelectorAll('.ui-select-match');
+          transcludedMatch.removeAttr('ui-select-match'); //To avoid loop in case directive as attr
           if (transcludedMatch.length !== 1) {
             throw uiSelectMinErr('transcluded', "Expected 1 .ui-select-match but got '{0}'.", transcludedMatch.length);
           }
           element.querySelectorAll('.ui-select-match').replaceWith(transcludedMatch);
 
           var transcludedChoices = transcluded.querySelectorAll('.ui-select-choices');
+          transcludedChoices.removeAttr('ui-select-choices'); //To avoid loop in case directive as attr
           if (transcludedChoices.length !== 1) {
             throw uiSelectMinErr('transcluded', "Expected 1 .ui-select-choices but got '{0}'.", transcludedChoices.length);
           }

Original file line number	Diff line number	Diff line change
`@@ -502,12 +502,14 @@`
`502`	`502`	`var transcluded = angular.element('<div>').append(clone);`
`503`	`503`
`504`	`504`	`var transcludedMatch = transcluded.querySelectorAll('.ui-select-match');`
	`505`	`+ transcludedMatch.removeAttr('ui-select-match'); //To avoid loop in case directive as attr`
`505`	`506`	`if (transcludedMatch.length !== 1) {`
`506`	`507`	`throw uiSelectMinErr('transcluded', "Expected 1 .ui-select-match but got '{0}'.", transcludedMatch.length);`
`507`	`508`	`}`
`508`	`509`	`element.querySelectorAll('.ui-select-match').replaceWith(transcludedMatch);`
`509`	`510`
`510`	`511`	`var transcludedChoices = transcluded.querySelectorAll('.ui-select-choices');`
	`512`	`+ transcludedChoices.removeAttr('ui-select-choices'); //To avoid loop in case directive as attr`
`511`	`513`	`if (transcludedChoices.length !== 1) {`
`512`	`514`	`throw uiSelectMinErr('transcluded', "Expected 1 .ui-select-choices but got '{0}'.", transcludedChoices.length);`
`513`	`515`	`}`