chore: broadcast updates in more places, add staleTime: Infinity

DanielleMaywood · DanielleMaywood · commit 00fdae6b6bf9 · 2025-07-14T15:18:54.000Z
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -549,6 +549,16 @@ func (api *API) Routes() http.Handler {
 	return r
 }
 
+func (api *API) broadcastUpdatesLocked() {
+	// Broadcast state changes to WebSocket listeners.
+	for _, ch := range api.updateChans {
+		select {
+		case ch <- struct{}{}:
+		default:
+		}
+	}
+}
+
 func (api *API) watchContainers(rw http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 
@@ -676,13 +686,7 @@ func (api *API) updateContainers(ctx context.Context) error {
 			})
 
 		if !statesAreEqual {
-			// Broadcast state changes to WebSocket listeners.
-			for _, ch := range api.updateChans {
-				select {
-				case ch <- struct{}{}:
-				default:
-				}
-			}
+			api.broadcastUpdatesLocked()
 		}
 	}
 
@@ -1056,6 +1060,8 @@ func (api *API) handleDevcontainerRecreate(w http.ResponseWriter, r *http.Reques
 	dc.Container = nil
 	dc.Error = ""
 	api.knownDevcontainers[dc.WorkspaceFolder] = dc
+	api.broadcastUpdatesLocked()
+
 	go func() {
 		_ = api.CreateDevcontainer(dc.WorkspaceFolder, dc.ConfigPath, WithRemoveExistingContainer())
 	}()
@@ -1171,6 +1177,7 @@ func (api *API) CreateDevcontainer(workspaceFolder, configPath string, opts ...D
 	dc.Error = ""
 	api.recreateSuccessTimes[dc.WorkspaceFolder] = api.clock.Now("agentcontainers", "recreate", "successTimes")
 	api.knownDevcontainers[dc.WorkspaceFolder] = dc
+	api.broadcastUpdatesLocked()
 	api.mu.Unlock()
 
 	// Ensure an immediate refresh to accurately reflect the
diff --git a/site/src/modules/resources/AgentDevcontainerCard.tsx b/site/src/modules/resources/AgentDevcontainerCard.tsx
@@ -130,12 +130,6 @@ export const AgentDevcontainerCard: FC<AgentDevcontainerCardProps> = ({
 
 			return { previousData };
 		},
-		onSuccess: async () => {
-			// Invalidate the containers query to refetch updated data.
-			await queryClient.invalidateQueries({
-				queryKey: ["agents", parentAgent.id, "containers"],
-			});
-		},
 		onError: (error, _, context) => {
 			// If the mutation fails, use the context returned from
 			// onMutate to roll back.
diff --git a/site/src/modules/resources/useAgentContainers.ts b/site/src/modules/resources/useAgentContainers.ts
@@ -19,6 +19,7 @@ export function useAgentContainers(
 		queryFn: () => API.getAgentContainers(agent.id),
 		enabled: agent.status === "connected",
 		select: (res) => res.devcontainers,
+		staleTime: Infinity,
 	});
 
 	const updateDevcontainersCache = useEffectEvent(
