lil cleanup

aslilac · aslilac · commit 68043536d9b4 · 2025-07-18T00:25:42.000Z
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -399,6 +399,7 @@ export class ParameterValidationError extends Error {
 		super("Parameters are not valid for new template version");
 	}
 }
+
 export type GetProvisionerJobsParams = {
 	status?: string;
 	limit?: number;
@@ -2199,9 +2200,9 @@ class ApiMethods {
 			default_value: p.default_value?.valid ? p.default_value.value : "",
 			options: p.options
 				? p.options.map((opt) => ({
-						...opt,
-						value: opt.value?.valid ? opt.value.value : "",
-					}))
+					...opt,
+					value: opt.value?.valid ? opt.value.value : "",
+				}))
 				: [],
 		}));
 	};
@@ -2284,6 +2285,8 @@ class ApiMethods {
 					rich_parameter_values: newBuildParameters,
 				});
 			} catch (error) {
+				// If the build failed because of a parameter validation error, then we
+				// throw a special sentinel error that can be caught by the caller.
 				if (
 					isApiError(error) &&
 					error.response.status === 400 &&
@@ -2625,7 +2628,7 @@ class ApiMethods {
 // All methods must be defined with arrow function syntax. See the docstring
 // above the ApiMethods class for a full explanation.
 class ExperimentalApiMethods {
-	constructor(protected readonly axios: AxiosInstance) {}
+	constructor(protected readonly axios: AxiosInstance) { }
 
 	getAITasksPrompts = async (
 		buildIds: TypesGen.WorkspaceBuild["id"][],
diff --git a/site/src/modules/workspaces/WorkspaceUpdateDialogs.tsx b/site/src/modules/workspaces/WorkspaceUpdateDialogs.tsx
@@ -157,7 +157,7 @@ const MissingBuildParametersDialog: FC<MissingBuildParametersDialogProps> = ({
 	const missedParameters =
 		error instanceof MissingBuildParameters ? error.parameters : [];
 	const versionId =
-		error instanceof MissingBuildParameters ? error.versionId : undefined;
+		error instanceof ParameterValidationError ? error.versionId : undefined;
 	const isOpen =
 		error instanceof MissingBuildParameters ||
 		error instanceof ParameterValidationError;
@@ -177,9 +177,7 @@ const MissingBuildParametersDialog: FC<MissingBuildParametersDialogProps> = ({
 			onClose={dialogProps.onClose}
 			workspaceOwnerName={workspace.owner_name}
 			workspaceName={workspace.name}
-			templateVersionId={
-				error instanceof ParameterValidationError ? error.versionId : undefined
-			}
+			templateVersionId={versionId}
 		/>
 	);
 };
