Skip to content

Commit ee42339

Browse files
author
Rajesh Akkineni
committed
Fixed more issues reported by vue-migration-helper
1 parent b2c201d commit ee42339

File tree

5 files changed

+9
-10
lines changed

5 files changed

+9
-10
lines changed

dist/vue-select.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/vue-select.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/Select.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
<div class="dropdown v-select" :class="dropdownClasses">
175175
<div ref="toggle" @mousedown.prevent="toggleDropdown" class="dropdown-toggle clearfix" type="button">
176176

177-
<span class="selected-tag" v-for="(option, index) in valueAsArray" track-by="index">
177+
<span class="selected-tag" v-for="option in valueAsArray" v-bind:key="index">
178178
{{ getOptionLabel(option) }}
179179
<button v-if="multiple" @click="select(option)" type="button" class="close">
180180
<span aria-hidden="true">&times;</span>
@@ -207,7 +207,7 @@
207207
</div>
208208

209209
<ul ref="dropdown-menu" v-show="open" :transition="transition" class="dropdown-menu" :style="{ 'max-height': maxHeight }">
210-
<li v-for="(option, index) in filteredOptions" track-by="index" :class="{ active: isOptionSelected(option), highlight: index === typeAheadPointer }" @mouseover="typeAheadPointer = index">
210+
<li v-for="(option, index) in filteredOptions" v-bind:key="index" :class="{ active: isOptionSelected(option), highlight: index === typeAheadPointer }" @mouseover="typeAheadPointer = index">
211211
<a @mousedown.prevent="select(option)">
212212
{{ getOptionLabel(option) }}
213213
</a>

src/dev.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import vSelect from '../src/components/Select.vue'
33

44
Vue.component('v-select', vSelect)
55

6-
Vue.config.debug = true
76
Vue.config.devtools = true
87

98
/* eslint-disable no-new */

src/mixins/pointerScroll.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
pixelsToPointerTop() {
3232
let pixelsToPointerTop = 0
3333
for (let i = 0; i < this.typeAheadPointer; i++) {
34-
pixelsToPointerTop += this.$els.dropdownMenu.children[i].offsetHeight
34+
pixelsToPointerTop += this.$refs.dropdownMenu.children[i].offsetHeight
3535
}
3636
return pixelsToPointerTop
3737
},
@@ -50,7 +50,7 @@ module.exports = {
5050
* @returns {number}
5151
*/
5252
pointerHeight() {
53-
let element = this.$els.dropdownMenu.children[this.typeAheadPointer]
53+
let element = this.$refs.dropdownMenu.children[this.typeAheadPointer]
5454
return element ? element.offsetHeight : 0
5555
},
5656

@@ -60,8 +60,8 @@ module.exports = {
6060
*/
6161
viewport() {
6262
return {
63-
top: this.$els.dropdownMenu.scrollTop,
64-
bottom: this.$els.dropdownMenu.offsetHeight + this.$els.dropdownMenu.scrollTop
63+
top: this.$refs.dropdownMenu.scrollTop,
64+
bottom: this.$refs.dropdownMenu.offsetHeight + this.$refs.dropdownMenu.scrollTop
6565
}
6666
},
6767

@@ -71,7 +71,7 @@ module.exports = {
7171
* @returns {*}
7272
*/
7373
scrollTo(position) {
74-
return this.$els.dropdownMenu.scrollTop = position
74+
return this.$refs.dropdownMenu.scrollTop = position
7575
},
7676
}
7777
}

0 commit comments

Comments
 (0)