Merge pull request shadowsocks#2221 from DamirAinullin/use_proxy_wrong_check

celeron533 · web-flow · commit 94cc6c523a78 · 2019-02-24T12:47:07.000+08:00
Improve the code readability useProxy test condition
diff --git a/shadowsocks-csharp/View/ProxyForm.cs b/shadowsocks-csharp/View/ProxyForm.cs
@@ -59,8 +59,8 @@ private void LoadCurrentConfiguration()
 
         private void OKButton_Click(object sender, EventArgs e)
         {
-
-            if (_modifiedProxyConfig.useProxy=UseProxyCheckBox.Checked)
+            _modifiedProxyConfig.useProxy = UseProxyCheckBox.Checked;
+            if (_modifiedProxyConfig.useProxy)
             {
                 if (!int.TryParse(ProxyPortTextBox.Text, out _modifiedProxyConfig.proxyPort))
                 {

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ private void LoadCurrentConfiguration()`
`59`	`59`
`60`	`60`	`private void OKButton_Click(object sender, EventArgs e)`
`61`	`61`	`{`
`62`		`-`
`63`		`- if (_modifiedProxyConfig.useProxy=UseProxyCheckBox.Checked)`
	`62`	`+ _modifiedProxyConfig.useProxy = UseProxyCheckBox.Checked;`
	`63`	`+ if (_modifiedProxyConfig.useProxy)`
`64`	`64`	`{`
`65`	`65`	`if (!int.TryParse(ProxyPortTextBox.Text, out _modifiedProxyConfig.proxyPort))`
`66`	`66`	`{`