Fix Quadruple.ATan2 #1

coder0xff · coder0xff · commit 1f8deb8fbb26 · 2016-06-08T12:24:30.000-04:00
diff --git a/QPFloat/ManagedQuadruple.cpp b/QPFloat/ManagedQuadruple.cpp
@@ -343,8 +343,8 @@ namespace System
 
 	System::Quadruple Quadruple::ATan2( Quadruple y, Quadruple x )
 	{
-		pin_ptr<byte> yPtr = x.storage;
-		pin_ptr<byte> xPtr = y.storage;
+		pin_ptr<byte> xPtr = x.storage;
+		pin_ptr<byte> yPtr = y.storage;
 		__float128 result = __float128::ATan2(*(__float128*)yPtr, *(__float128*)xPtr);
 		return *(Quadruple*)&result;
 	}
@@ -451,9 +451,10 @@ namespace System
 		str = str->Trim();
 		System::Text::StringBuilder^ s = gcnew System::Text::StringBuilder(str);
 		Quadruple result = 0;
+		bool negative = false;
 		if (s->default[0] == '-')
 		{
-			result.IsSigned = true;
+			negative = true;
 			s->Remove(0, 1);
 		}
 		Quadruple ten = 10;
@@ -487,6 +488,7 @@ namespace System
 		}
 		Quadruple temp = Quadruple::Pow(ten, -postDecimalDigits);
 		Quadruple::Mul(result, temp, result);
+		result.IsSigned = negative;
 		return result;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -343,8 +343,8 @@ namespace System`
`343`	`343`
`344`	`344`	`System::Quadruple Quadruple::ATan2( Quadruple y, Quadruple x )`
`345`	`345`	`{`
`346`		`- pin_ptr<byte> yPtr = x.storage;`
`347`		`- pin_ptr<byte> xPtr = y.storage;`
	`346`	`+ pin_ptr<byte> xPtr = x.storage;`
	`347`	`+ pin_ptr<byte> yPtr = y.storage;`
`348`	`348`	`__float128 result = __float128::ATan2((__float128)yPtr, (__float128)xPtr);`
`349`	`349`	`return (Quadruple)&result;`
`350`	`350`	`}`
`@@ -451,9 +451,10 @@ namespace System`
`451`	`451`	`str = str->Trim();`
`452`	`452`	`System::Text::StringBuilder^ s = gcnew System::Text::StringBuilder(str);`
`453`	`453`	`Quadruple result = 0;`
	`454`	`+ bool negative = false;`
`454`	`455`	`if (s->default[0] == '-')`
`455`	`456`	`{`
`456`		`- result.IsSigned = true;`
	`457`	`+ negative = true;`
`457`	`458`	`s->Remove(0, 1);`
`458`	`459`	`}`
`459`	`460`	`Quadruple ten = 10;`
`@@ -487,6 +488,7 @@ namespace System`
`487`	`488`	`}`
`488`	`489`	`Quadruple temp = Quadruple::Pow(ten, -postDecimalDigits);`
`489`	`490`	`Quadruple::Mul(result, temp, result);`
	`491`	`+ result.IsSigned = negative;`
`490`	`492`	`return result;`
`491`	`493`	`}`
`492`	`494`	`}`