perf[utils.js]: Add code comments to deepClone and remove redundant code

PanJiaChen · PanJiaChen · commit 3f479664b6ed · 2018-06-19T11:26:46.000+08:00
diff --git a/src/utils/index.js b/src/utils/index.js
@@ -246,14 +246,18 @@ export function debounce(func, wait, immediate) {
   }
 }
 
+/**
+ * This is just a simple version of deep copy
+ * Has a lot of edge cases bug
+ * If you want to use a perfect deep copy, use lodash's _.cloneDeep
+ */
 export function deepClone(source) {
   if (!source && typeof source !== 'object') {
     throw new Error('error arguments', 'shallowClone')
   }
   const targetObj = source.constructor === Array ? [] : {}
   Object.keys(source).forEach((keys) => {
     if (source[keys] && typeof source[keys] === 'object') {
-      targetObj[keys] = source[keys].constructor === Array ? [] : {}
       targetObj[keys] = deepClone(source[keys])
     } else {
       targetObj[keys] = source[keys]

Original file line number	Diff line number	Diff line change
`@@ -246,14 +246,18 @@ export function debounce(func, wait, immediate) {`
`246`	`246`	`}`
`247`	`247`	`}`
`248`	`248`
	`249`	`+/**`
	`250`	`+ * This is just a simple version of deep copy`
	`251`	`+ * Has a lot of edge cases bug`
	`252`	`+ * If you want to use a perfect deep copy, use lodash's _.cloneDeep`
	`253`	`+ */`
`249`	`254`	`export function deepClone(source) {`
`250`	`255`	`if (!source && typeof source !== 'object') {`
`251`	`256`	`throw new Error('error arguments', 'shallowClone')`
`252`	`257`	`}`
`253`	`258`	`const targetObj = source.constructor === Array ? [] : {}`
`254`	`259`	`Object.keys(source).forEach((keys) => {`
`255`	`260`	`if (source[keys] && typeof source[keys] === 'object') {`
`256`		`- targetObj[keys] = source[keys].constructor === Array ? [] : {}`
`257`	`261`	`targetObj[keys] = deepClone(source[keys])`
`258`	`262`	`} else {`
`259`	`263`	`targetObj[keys] = source[keys]`