Skip to content

Commit ba17775

Browse files
denzelsNdenzelsN
committed
Merge pull request pinpoint-apm#1666 from denzelsN/master
add new analytics event.
2 parents a362b03 + fb26f29 commit ba17775

File tree

10 files changed

+20
-16
lines changed

10 files changed

+20
-16
lines changed

‎web/src/main/webapp/common/services/analytics.service.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@
6262
this.CONST.CLK_REALTIME_CHART_PIN_ON = "ClickRealtimeChartPinOn";
6363
this.CONST.CLK_REALTIME_CHART_PIN_OFF = "ClickRealtimeChartPinOff";
6464
this.CONST.CLK_SHOW_SERVER_TYPE_DETAIL = "ClickShowServerTypeDetail";
65-
this.CONST.CLK_CHANGE_AGENT = "ClickChangeAgent";
65+
this.CONST.CLK_CHANGE_AGENT_INSPECTOR = "ClickChangeAgentInspector";
66+
this.CONST.CLK_CHANGE_AGENT_MAIN = "ClickChangeAgentMain";
6667
this.CONST.CLK_START_REALTIME = "ClickStartRealtime";
6768

6869
this.CONST.CLK_CONFIGURATION = "ClickConfiguration";

‎web/src/main/webapp/components/server-map2/jquery.ServerMap2.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1284,7 +1284,9 @@
12841284
htData = node.data,
12851285
fOnNodeClicked = this.option('fOnNodeClicked');
12861286
if (angular.isFunction(fOnNodeClicked)) {
1287-
this.analyticsService.send(this.analyticsService.CONST.MAIN, this.analyticsService.CONST.CLK_NODE);
1287+
if ( e.clickCount > 0 ) {
1288+
this.analyticsService.send(this.analyticsService.CONST.MAIN, this.analyticsService.CONST.CLK_NODE);
1289+
}
12881290
fOnNodeClicked.call(this, e, htData, unknownKey, query);
12891291
}
12901292
},

‎web/src/main/webapp/features/agentList/agent-list.directive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
};
6161

6262
scope.select = function (agent) {
63-
analyticsService.send( analyticsService.CONST.INSPECTOR, analyticsService.CONST.CLK_CHANGE_AGENT );
63+
analyticsService.send( analyticsService.CONST.INSPECTOR, analyticsService.CONST.CLK_CHANGE_AGENT_INSPECTOR );
6464
scope.currentAgent = agent;
6565
scope.$emit('agentListDirective.agentChanged', agent);
6666
};

‎web/src/main/webapp/features/responseTimeChart/response-time-chart.directive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@
9898
// $at($at.MAIN, $at.CLK_RESPONSE_GRAPH);
9999
// });
100100
oChart.addListener('clickGraphItem', function(event) {
101-
analyticsService.send(analyticsService.CONST.MAIN, analyticsService.CONST.CLK_RESPONSE_GRAPH);
102101
if ( event.item.category == "Error" ) {
102+
analyticsService.send(analyticsService.CONST.MAIN, analyticsService.CONST.CLK_RESPONSE_GRAPH);
103103
scope.$emit('responseTimeChartDirective.showErrorTransacitonList', event.item.category );
104104
}
105105
if ( useFilterTransaction ) {

‎web/src/main/webapp/features/sidebar/title/sidebar-title.directive.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
* @name sidebarTitleDirective
88
* @class
99
*/
10-
pinpointApp.directive("sidebarTitleDirective", [ "$timeout", "$rootScope", "PreferenceService",
11-
function ( $timeout, $rootScope, preferenceService ) {
10+
pinpointApp.directive("sidebarTitleDirective", [ "$timeout", "$rootScope", "PreferenceService", "AnalyticsService",
11+
function ( $timeout, $rootScope, preferenceService, analyticsService ) {
1212
return {
1313
restrict: "E",
1414
replace: true,
@@ -66,6 +66,7 @@
6666
scope.agentList = [];
6767
}
6868
scope.changeAgent = function() {
69+
analyticsService.send( analyticsService.CONST.INSPECTOR, analyticsService.CONST.CLK_CHANGE_AGENT_MAIN );
6970
$rootScope.$broadcast("changedCurrentAgent", scope.currentAgent );
7071
};
7172
/**

‎web/src/main/webapp/lib/js/pinpoint-component.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎web/src/main/webapp/lib/js/pinpoint-component.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎web/src/main/webapp/lib/js/pinpoint.min.js

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎web/src/main/webapp/lib/js/pinpoint.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎web/src/main/webapp/lib/js/server-map2.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)