deps: update ESLint version to v7 (facebook#18897)

koba04 · web-flow · commit 039ad34a0599 · 2020-05-12T18:41:37.000+01:00
diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
     "cross-env": "^6.0.3",
     "danger": "^9.2.10",
     "error-stack-parser": "^2.0.6",
-    "eslint": "^6.8.0",
+    "eslint": "^7.0.0",
     "eslint-config-fbjs": "^1.1.1",
     "eslint-config-prettier": "^6.9.0",
     "eslint-plugin-babel": "^5.3.0",
diff --git a/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js b/scripts/eslint-rules/__tests__/no-production-logging-test.internal.js
@@ -110,6 +110,7 @@ ruleTester.run('no-production-logging', rule, {
   invalid: [
     {
       code: "console.error('Oh no');",
+      output: "if (__DEV__) {console.error('Oh no')};",
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -118,6 +119,7 @@ ruleTester.run('no-production-logging', rule, {
     },
     {
       code: "console.warn('Oh no');",
+      output: "if (__DEV__) {console.warn('Oh no')};",
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -126,6 +128,7 @@ ruleTester.run('no-production-logging', rule, {
     },
     {
       code: "console.warn('Oh no')",
+      output: "if (__DEV__) {console.warn('Oh no')}",
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -138,6 +141,11 @@ ruleTester.run('no-production-logging', rule, {
           console.warn('Oh no');
         }
       `,
+      output: `
+        if (potato) {
+          if (__DEV__) {console.warn('Oh no')};
+        }
+      `,
       errors: [
         {
           message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
@@ -150,6 +158,11 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
+      output: `
+        if (__DEV__ || potato && true) {
+          if (__DEV__) {console.error('Oh no')};
+        }
+      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -162,6 +175,11 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
+      output: `
+        if (banana && __DEV__ && potato && kitten) {
+          if (__DEV__) {console.error('Oh no')};
+        }
+      `,
       // Technically this code is valid but we prefer
       // explicit standalone __DEV__ blocks that stand out.
       errors: [
@@ -176,6 +194,11 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
+      output: `
+        if (!__DEV__) {
+          if (__DEV__) {console.error('Oh no')};
+        }
+      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -188,6 +211,11 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
+      output: `
+        if (foo || x && __DEV__) {
+          if (__DEV__) {console.error('Oh no')};
+        }
+      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -201,6 +229,12 @@ ruleTester.run('no-production-logging', rule, {
           console.error('Oh no');
         }
       `,
+      output: `
+        if (__DEV__) {
+        } else {
+          if (__DEV__) {console.error('Oh no')};
+        }
+      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
@@ -217,6 +251,15 @@ ruleTester.run('no-production-logging', rule, {
           }
         }
       `,
+      output: `
+        if (__DEV__) {
+        } else {
+          if (__DEV__) {
+          } else {
+            if (__DEV__) {console.error('Oh no')};
+          }
+        }
+      `,
       errors: [
         {
           message: `Wrap console.error() in an "if (__DEV__) {}" check`,
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,7 @@ ruleTester.run('no-production-logging', rule, {`
`110`	`110`	`invalid: [`
`111`	`111`	`{`
`112`	`112`	`code: "console.error('Oh no');",`
	`113`	`+ output: "if (__DEV__) {console.error('Oh no')};",`
`113`	`114`	`errors: [`
`114`	`115`	`{`
`115`	`116`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,
`@@ -118,6 +119,7 @@ ruleTester.run('no-production-logging', rule, {`
`118`	`119`	`},`
`119`	`120`	`{`
`120`	`121`	`code: "console.warn('Oh no');",`
	`122`	`+ output: "if (__DEV__) {console.warn('Oh no')};",`
`121`	`123`	`errors: [`
`122`	`124`	`{`
`123`	`125`	message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
`@@ -126,6 +128,7 @@ ruleTester.run('no-production-logging', rule, {`
`126`	`128`	`},`
`127`	`129`	`{`
`128`	`130`	`code: "console.warn('Oh no')",`
	`131`	`+ output: "if (__DEV__) {console.warn('Oh no')}",`
`129`	`132`	`errors: [`
`130`	`133`	`{`
`131`	`134`	message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
`@@ -138,6 +141,11 @@ ruleTester.run('no-production-logging', rule, {`
`138`	`141`	`console.warn('Oh no');`
`139`	`142`	`}`
`140`	`143`	`,
	`144`	+ output: `
	`145`	`+ if (potato) {`
	`146`	`+ if (__DEV__) {console.warn('Oh no')};`
	`147`	`+ }`
	`148`	+ `,
`141`	`149`	`errors: [`
`142`	`150`	`{`
`143`	`151`	message: `Wrap console.warn() in an "if (__DEV__) {}" check`,
`@@ -150,6 +158,11 @@ ruleTester.run('no-production-logging', rule, {`
`150`	`158`	`console.error('Oh no');`
`151`	`159`	`}`
`152`	`160`	`,
	`161`	+ output: `
	`162`	`+ if (__DEV__ \|\| potato && true) {`
	`163`	`+ if (__DEV__) {console.error('Oh no')};`
	`164`	`+ }`
	`165`	+ `,
`153`	`166`	`errors: [`
`154`	`167`	`{`
`155`	`168`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,
`@@ -162,6 +175,11 @@ ruleTester.run('no-production-logging', rule, {`
`162`	`175`	`console.error('Oh no');`
`163`	`176`	`}`
`164`	`177`	`,
	`178`	+ output: `
	`179`	`+ if (banana && __DEV__ && potato && kitten) {`
	`180`	`+ if (__DEV__) {console.error('Oh no')};`
	`181`	`+ }`
	`182`	+ `,
`165`	`183`	`// Technically this code is valid but we prefer`
`166`	`184`	`// explicit standalone __DEV__ blocks that stand out.`
`167`	`185`	`errors: [`
`@@ -176,6 +194,11 @@ ruleTester.run('no-production-logging', rule, {`
`176`	`194`	`console.error('Oh no');`
`177`	`195`	`}`
`178`	`196`	`,
	`197`	+ output: `
	`198`	`+ if (!__DEV__) {`
	`199`	`+ if (__DEV__) {console.error('Oh no')};`
	`200`	`+ }`
	`201`	+ `,
`179`	`202`	`errors: [`
`180`	`203`	`{`
`181`	`204`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,
`@@ -188,6 +211,11 @@ ruleTester.run('no-production-logging', rule, {`
`188`	`211`	`console.error('Oh no');`
`189`	`212`	`}`
`190`	`213`	`,
	`214`	+ output: `
	`215`	`+ if (foo \|\| x && __DEV__) {`
	`216`	`+ if (__DEV__) {console.error('Oh no')};`
	`217`	`+ }`
	`218`	+ `,
`191`	`219`	`errors: [`
`192`	`220`	`{`
`193`	`221`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,
`@@ -201,6 +229,12 @@ ruleTester.run('no-production-logging', rule, {`
`201`	`229`	`console.error('Oh no');`
`202`	`230`	`}`
`203`	`231`	`,
	`232`	+ output: `
	`233`	`+ if (__DEV__) {`
	`234`	`+ } else {`
	`235`	`+ if (__DEV__) {console.error('Oh no')};`
	`236`	`+ }`
	`237`	+ `,
`204`	`238`	`errors: [`
`205`	`239`	`{`
`206`	`240`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,
`@@ -217,6 +251,15 @@ ruleTester.run('no-production-logging', rule, {`
`217`	`251`	`}`
`218`	`252`	`}`
`219`	`253`	`,
	`254`	+ output: `
	`255`	`+ if (__DEV__) {`
	`256`	`+ } else {`
	`257`	`+ if (__DEV__) {`
	`258`	`+ } else {`
	`259`	`+ if (__DEV__) {console.error('Oh no')};`
	`260`	`+ }`
	`261`	`+ }`
	`262`	+ `,
`220`	`263`	`errors: [`
`221`	`264`	`{`
`222`	`265`	message: `Wrap console.error() in an "if (__DEV__) {}" check`,