Allow publishing untagged releases (facebook#19505)

gaearon · web-flow · commit 7543459a4819 · 2020-07-31T16:10:01.000+01:00
diff --git a/scripts/release/README.md b/scripts/release/README.md
@@ -20,6 +20,10 @@ The high level process of creating releases is [documented below](#process). Ind
 
 If this is your first time running the release scripts, go to the `scripts/release` directory and run `yarn` to install the dependencies.
 
+## Publishing Without Tags
+
+The sections bekow include meaningful `--tags` in the instructions. However, keep in mind that **the `--tags` arguments is optional**, and you can omit it if you don't want to tag the release on npm at all. This can be useful when preparing breaking changes.
+
 ## Publishing Next
 
 "Next" builds are meant to be lightweight and published often. In most cases, they can be published using artifacts built by Circle CI.
diff --git a/scripts/release/publish-commands/confirm-version-and-tags.js b/scripts/release/publish-commands/confirm-version-and-tags.js
@@ -11,15 +11,19 @@ const theme = require('../theme');
 const run = async ({cwd, packages, tags}) => {
   clear();
 
-  if (tags.length === 1) {
+  if (tags.length === 0) {
     console.log(
-      theme`{spinnerSuccess ✓} You are about the publish the following packages under the tag {tag ${tags}}`
+      theme`{spinnerSuccess ✓} You are about the publish the following packages without any tags:`
+    );
+  } else if (tags.length === 1) {
+    console.log(
+      theme`{spinnerSuccess ✓} You are about the publish the following packages under the tag {tag ${tags}}:`
     );
   } else {
     console.log(
       theme`{spinnerSuccess ✓} You are about the publish the following packages under the tags {tag ${tags.join(
         ', '
-      )}}`
+      )}}:`
     );
   }
 
diff --git a/scripts/release/publish-commands/parse-params.js b/scripts/release/publish-commands/parse-params.js
@@ -3,7 +3,6 @@
 'use strict';
 
 const commandLineArgs = require('command-line-args');
-const commandLineUsage = require('command-line-usage');
 const {splitCommaParams} = require('../utils');
 
 const paramDefinitions = [
@@ -30,39 +29,10 @@ const paramDefinitions = [
 
 module.exports = () => {
   const params = commandLineArgs(paramDefinitions);
-
-  const {skipPackages, tags} = params;
-
-  if (!tags || tags.length === 0) {
-    const usage = commandLineUsage([
-      {
-        content:
-          'Publishes the current contents of "build/node_modules" to NPM.',
-      },
-      {
-        header: 'Options',
-        optionList: paramDefinitions,
-      },
-      {
-        header: 'Examples',
-        content: [
-          {
-            desc: 'Dry run test:',
-            example: '$ scripts/release/publish.js --dry --tags next',
-          },
-          {
-            desc: 'Publish a new stable:',
-            example: '$ scripts/release/publish.js --tags next latest',
-          },
-        ],
-      },
-    ]);
-    console.log(usage);
-    process.exit(1);
+  if (!params.tags || !params.tags.length) {
+    params.tags = [];
   }
-
-  splitCommaParams(skipPackages);
-  splitCommaParams(tags);
-
+  splitCommaParams(params.skipPackages);
+  splitCommaParams(params.tags);
   return params;
 };
