Remove .internal from more test suites (facebook#18597)

acdlite · web-flow · commit 843b50cbe154 · 2020-04-14T07:43:00.000-07:00
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.js
diff --git a/packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js b/packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js
@@ -43,8 +43,6 @@ describe('ReactHooksWithNoopRenderer', () => {
 
     ReactFeatureFlags = require('shared/ReactFeatureFlags');
 
-    ReactFeatureFlags.enableSchedulerTracing = true;
-    ReactFeatureFlags.enableProfilerTimer = true;
     deferPassiveEffectCleanupDuringUnmount =
       ReactFeatureFlags.deferPassiveEffectCleanupDuringUnmount;
     runAllPassiveEffectDestroysBeforeCreates =
@@ -1611,6 +1609,7 @@ describe('ReactHooksWithNoopRenderer', () => {
       expect(ReactNoop.getChildren()).toEqual([span('Count: 2')]);
     });
 
+    // @gate enableSchedulerTracing
     it('flushes passive effects when flushing discrete updates (with tracing)', () => {
       const onInteractionScheduledWorkCompleted = jest.fn();
       const onWorkCanceled = jest.fn();
diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js
@@ -1,5 +1,4 @@
 let React;
-let ReactFeatureFlags;
 let ReactNoop;
 let Scheduler;
 let Suspense;
@@ -8,10 +7,7 @@ let SuspenseList;
 describe('ReactSuspenseList', () => {
   beforeEach(() => {
     jest.resetModules();
-    ReactFeatureFlags = require('shared/ReactFeatureFlags');
 
-    ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
-    ReactFeatureFlags.enableSuspenseServerRenderer = true;
     React = require('react');
     ReactNoop = require('react-noop-renderer');
     Scheduler = require('scheduler');
diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
@@ -15,8 +15,6 @@ describe('ReactSuspenseWithNoopRenderer', () => {
     jest.resetModules();
 
     ReactFeatureFlags = require('shared/ReactFeatureFlags');
-
-    ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
     React = require('react');
     Fragment = React.Fragment;
     ReactNoop = require('react-noop-renderer');
@@ -339,6 +337,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {
     ]);
   });
 
+  // Second condition is redundant but guarantees that the test runs in prod.
+  // TODO: Delete this feature flag.
+  // @gate !replayFailedUnitOfWorkWithInvokeGuardedCallback || !__DEV__
   it('retries on error', async () => {
     class ErrorBoundary extends React.Component {
       state = {error: null};
@@ -395,6 +396,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {
     ]);
   });
 
+  // Second condition is redundant but guarantees that the test runs in prod.
+  // TODO: Delete this feature flag.
+  // @gate !replayFailedUnitOfWorkWithInvokeGuardedCallback || !__DEV__
   it('retries on error after falling back to a placeholder', async () => {
     class ErrorBoundary extends React.Component {
       state = {error: null};
diff --git a/packages/react-reconciler/src/__tests__/ReactTransition-test.js b/packages/react-reconciler/src/__tests__/ReactTransition-test.js
diff --git a/packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js b/packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js
@@ -57,8 +57,8 @@ export const shouldSetTextContent = $$$hostConfig.shouldSetTextContent;
 export const shouldDeprioritizeSubtree =
   $$$hostConfig.shouldDeprioritizeSubtree;
 export const createTextInstance = $$$hostConfig.createTextInstance;
-export const scheduleTimeout = $$$hostConfig.setTimeout;
-export const cancelTimeout = $$$hostConfig.clearTimeout;
+export const scheduleTimeout = $$$hostConfig.scheduleTimeout;
+export const cancelTimeout = $$$hostConfig.cancelTimeout;
 export const noTimeout = $$$hostConfig.noTimeout;
 export const now = $$$hostConfig.now;
 export const isPrimaryRenderer = $$$hostConfig.isPrimaryRenderer;
