Make NoWork big instead of small

sophiebits · sophiebits · commit a684f09e5823 · 2018-10-20T00:16:42.000-07:00
diff --git a/packages/react-reconciler/src/ReactFiberExpirationTime.js b/packages/react-reconciler/src/ReactFiberExpirationTime.js
@@ -11,9 +11,9 @@ import MAX_SIGNED_31_BIT_INT from './maxSigned31BitInt';
 
 export type ExpirationTime = number;
 
-export const NoWork = 0;
+export const NoWork = MAX_SIGNED_31_BIT_INT;
 export const Sync = 1;
-export const Never = MAX_SIGNED_31_BIT_INT;
+export const Never = MAX_SIGNED_31_BIT_INT - 1;
 
 const UNIT_SIZE = 10;
 const MAGIC_NUMBER_OFFSET = 2;
diff --git a/packages/react-reconciler/src/ReactFiberScheduler.js b/packages/react-reconciler/src/ReactFiberScheduler.js
@@ -1545,7 +1545,10 @@ function computeExpirationForFiber(currentTime: ExpirationTime, fiber: Fiber) {
     // This is an interactive update. Keep track of the lowest pending
     // interactive expiration time. This allows us to synchronously flush
     // all interactive updates when needed.
-    if (expirationTime > lowestPriorityPendingInteractiveExpirationTime) {
+    if (
+      lowestPriorityPendingInteractiveExpirationTime === NoWork ||
+      expirationTime > lowestPriorityPendingInteractiveExpirationTime
+    ) {
       lowestPriorityPendingInteractiveExpirationTime = expirationTime;
     }
   }
diff --git a/packages/react-reconciler/src/__tests__/__snapshots__/ReactIncrementalPerf-test.internal.js.snap b/packages/react-reconciler/src/__tests__/__snapshots__/ReactIncrementalPerf-test.internal.js.snap
@@ -249,7 +249,7 @@ exports[`ReactDebugFiberPerf measures deprioritized work 1`] = `
   ⚛ (Committing Host Effects: 1 Total)
   ⚛ (Calling Lifecycle Methods: 0 Total)
 
-⚛ (Waiting for async callback... will force flush in 10737418210 ms)
+⚛ (Waiting for async callback... will force flush in 10737418200 ms)
 
 // Flush the child
 ⚛ (React Tree Reconciliation: Completed Root)

Original file line number	Diff line number	Diff line change
`@@ -1545,7 +1545,10 @@ function computeExpirationForFiber(currentTime: ExpirationTime, fiber: Fiber) {`
`1545`	`1545`	`// This is an interactive update. Keep track of the lowest pending`
`1546`	`1546`	`// interactive expiration time. This allows us to synchronously flush`
`1547`	`1547`	`// all interactive updates when needed.`
`1548`		`- if (expirationTime > lowestPriorityPendingInteractiveExpirationTime) {`
	`1548`	`+ if (`
	`1549`	`+ lowestPriorityPendingInteractiveExpirationTime === NoWork \|\|`
	`1550`	`+ expirationTime > lowestPriorityPendingInteractiveExpirationTime`
	`1551`	`+ ) {`
`1549`	`1552`	`lowestPriorityPendingInteractiveExpirationTime = expirationTime;`
`1550`	`1553`	`}`
`1551`	`1554`	`}`