Disable (unstable) scheduler sampling profiler for OSS builds (facebook#20832)

Brian Vaughn · gaearon · commit b2bbee7ba31b · 2021-03-22T19:57:29.000Z
* Disabled Scheduler sampling profiler for OSS builds
* Added missing conditional feature flag around profiling calls
diff --git a/packages/scheduler/src/Scheduler.js b/packages/scheduler/src/Scheduler.js
@@ -181,12 +181,16 @@ function workLoop(hasTimeRemaining, initialTime) {
       currentTask.callback = null;
       currentPriorityLevel = currentTask.priorityLevel;
       const didUserCallbackTimeout = currentTask.expirationTime <= currentTime;
-      markTaskRun(currentTask, currentTime);
+      if (enableProfiling) {
+        markTaskRun(currentTask, currentTime);
+      }
       const continuationCallback = callback(didUserCallbackTimeout);
       currentTime = getCurrentTime();
       if (typeof continuationCallback === 'function') {
         currentTask.callback = continuationCallback;
-        markTaskYield(currentTask, currentTime);
+        if (enableProfiling) {
+          markTaskYield(currentTask, currentTime);
+        }
       } else {
         if (enableProfiling) {
           markTaskCompleted(currentTask, currentTime);
diff --git a/packages/scheduler/src/SchedulerFeatureFlags.js b/packages/scheduler/src/SchedulerFeatureFlags.js
@@ -8,4 +8,4 @@
 
 export const enableSchedulerDebugging = false;
 export const enableIsInputPending = false;
-export const enableProfiling = __PROFILE__;
+export const enableProfiling = false;
diff --git a/packages/scheduler/src/__tests__/SchedulerProfiling-test.js b/packages/scheduler/src/__tests__/SchedulerProfiling-test.js
@@ -44,7 +44,8 @@ function priorityLevelToString(priorityLevel) {
 }
 
 describe('Scheduler', () => {
-  if (!__PROFILE__) {
+  const {enableProfiling} = require('scheduler/src/SchedulerFeatureFlags');
+  if (!enableProfiling) {
     // The tests in this suite only apply when profiling is on
     it('profiling APIs are not available', () => {
       Scheduler = require('scheduler');

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ function priorityLevelToString(priorityLevel) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`describe('Scheduler', () => {`
`47`		`- if (!__PROFILE__) {`
	`47`	`+ const {enableProfiling} = require('scheduler/src/SchedulerFeatureFlags');`
	`48`	`+ if (!enableProfiling) {`
`48`	`49`	`// The tests in this suite only apply when profiling is on`
`49`	`50`	`it('profiling APIs are not available', () => {`
`50`	`51`	`Scheduler = require('scheduler');`