Skip to content

Commit 9838337

Browse files
bz2brian-brazil
authored andcommitted
Fix F811 redefinition lint (prometheus#239)
This was masking two test cases that should have been being run.
1 parent 524b616 commit 9838337

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

tests/test_core.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def test_gauge(self):
7474
self.gauge.set(9)
7575
self.assertEqual(9, self.registry.get_sample_value('g'))
7676

77-
def test_function_decorator(self):
77+
def test_inprogress_function_decorator(self):
7878
self.assertEqual(0, self.registry.get_sample_value('g'))
7979

8080
@self.gauge.track_inprogress()
@@ -86,7 +86,7 @@ def f():
8686
f()
8787
self.assertEqual(0, self.registry.get_sample_value('g'))
8888

89-
def test_block_decorator(self):
89+
def test_inprogress_block_decorator(self):
9090
self.assertEqual(0, self.registry.get_sample_value('g'))
9191
with self.gauge.track_inprogress():
9292
self.assertEqual(1, self.registry.get_sample_value('g'))
@@ -101,7 +101,7 @@ def test_gauge_function(self):
101101
x['a'] = None
102102
self.assertEqual(1, self.registry.get_sample_value('g'))
103103

104-
def test_function_decorator(self):
104+
def test_time_function_decorator(self):
105105
self.assertEqual(0, self.registry.get_sample_value('g'))
106106

107107
@self.gauge.time()
@@ -113,7 +113,7 @@ def f():
113113
f()
114114
self.assertNotEqual(0, self.registry.get_sample_value('g'))
115115

116-
def test_block_decorator(self):
116+
def test_time_block_decorator(self):
117117
self.assertEqual(0, self.registry.get_sample_value('g'))
118118
with self.gauge.time():
119119
time.sleep(.001)

tox.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ ignore =
8282
F401,
8383
F403,
8484
F405,
85-
F811,
8685
F841,
8786
W293,
8887
W503

0 commit comments

Comments
 (0)