Skip to content

Commit 6866dee

Browse files
author
Jeff
committed
Merge branch 'click-tag-to-toggle-dropdown' of https://github.com/stevenharman/vue-select into stevenharman-click-tag-to-toggle-dropdown
# Conflicts: # src/components/Select.vue
2 parents 3d819e5 + 76cfd7c commit 6866dee

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/components/Select.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,7 @@
874874
*/
875875
toggleDropdown(e) {
876876
if (e.target === this.$refs.openIndicator || e.target === this.$refs.search || e.target === this.$refs.toggle ||
877-
e.target === this.$refs.selectedOptions || e.target === this.$el) {
877+
e.target.classList.contains('selected-tag') || e.target === this.$el) {
878878
if (this.open) {
879879
this.$refs.search.blur() // dropdown will close on blur
880880
} else {

test/unit/specs/Select.spec.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,26 @@ describe('Select.vue', () => {
403403
})
404404
})
405405

406+
it('should open the dropdown when the selected tag is clicked', (done) => {
407+
const vm = new Vue({
408+
template: '<div><v-select :options="options" :value="value"></v-select></div>',
409+
components: {vSelect},
410+
data: {
411+
value: [{label: 'one'}],
412+
options: [{label: 'one'}]
413+
}
414+
}).$mount()
415+
416+
const selectedTag = vm.$children[0].$el.getElementsByClassName('selected-tag')[0]
417+
vm.$children[0].toggleDropdown({target: selectedTag})
418+
Vue.nextTick(() => {
419+
Vue.nextTick(() => {
420+
expect(vm.$children[0].open).toEqual(true)
421+
done()
422+
})
423+
})
424+
})
425+
406426
it('can close the dropdown when the el is clicked', (done) => {
407427
const vm = new Vue({
408428
template: '<div><v-select></v-select></div>',

0 commit comments

Comments
 (0)