fix isValueEmpty bug when working with integers

Jeff · Jeff · commit b92428101f1c · 2018-01-28T17:54:25.000-08:00
diff --git a/src/components/Select.vue b/src/components/Select.vue
@@ -1080,9 +1080,9 @@
       isValueEmpty() {
         if (this.mutableValue) {
           if (typeof this.mutableValue === 'object') {
-            return !Object.keys(this.mutableValue).length
+            return ! Object.keys(this.mutableValue).length
           }
-          return !this.mutableValue.length
+          return ! this.valueAsArray.length
         }
 
         return true;
diff --git a/test/unit/specs/Select.spec.js b/test/unit/specs/Select.spec.js
@@ -249,7 +249,20 @@ describe('Select.vue', () => {
 			expect(vm.$children[0].isOptionSelected('foo')).toEqual(true)
 		}),
 
-		describe('change Event', () => {
+		it('can work with an array of integers', () => {
+			const vm = new Vue({
+				template: '<div><v-select :options="[1,2,3,4,5]" v-model="value"></v-select></div>',
+				components: {vSelect},
+				data: {
+					value: 5,
+				}
+			}).$mount()
+
+			expect(vm.$children[0].isOptionSelected(5)).toEqual(true)
+			expect(vm.$children[0].isValueEmpty).toEqual(false)
+		})
+
+    describe('change Event', () => {
 			it('will trigger the input event when the selection changes', (done) => {
 				const vm = new Vue({
 					template: `<div><v-select ref="select"  :value="['foo']" :options="['foo','bar','baz']" v-on:input="foo = arguments[0]"></v-select></div>`,
@@ -1564,7 +1577,7 @@ describe('Select.vue', () => {
 		})
 	})
 
-	describe( 'Clear button', () => {
+	describe('Clear button', () => {
 
 		it( 'should be displayed on single select when value is selected', () => {
 			const VueSelect = Vue.extend( vSelect )

Original file line number	Diff line number	Diff line change
`@@ -1080,9 +1080,9 @@`
`1080`	`1080`	`isValueEmpty() {`
`1081`	`1081`	`if (this.mutableValue) {`
`1082`	`1082`	`if (typeof this.mutableValue === 'object') {`
`1083`		`- return !Object.keys(this.mutableValue).length`
	`1083`	`+ return ! Object.keys(this.mutableValue).length`
`1084`	`1084`	`}`
`1085`		`- return !this.mutableValue.length`
	`1085`	`+ return ! this.valueAsArray.length`
`1086`	`1086`	`}`
`1087`	`1087`
`1088`	`1088`	`return true;`