multiple mode - add/remove support vuex strictmode (sagalbot#702)

eriknygren · sagalbot · commit d8635e7ccdd5 · 2019-02-10T20:06:19.000-08:00
What
---
- In multiple mode: Update adding or removing a value to use
spread operator or filter, instead of mutating the array directly.

Why
---
So vuex strict mode doesn't throw warnings.
diff --git a/src/components/Select.vue b/src/components/Select.vue
@@ -844,7 +844,7 @@
           if (this.multiple && !this.mutableValue) {
             this.mutableValue = [option]
           } else if (this.multiple) {
-            this.mutableValue.push(option)
+            this.mutableValue = [...this.mutableValue, option]
           } else {
             this.mutableValue = option
           }
@@ -867,8 +867,7 @@
               ref = val
             }
           })
-          var index = this.mutableValue.indexOf(ref)
-          this.mutableValue.splice(index, 1)
+          this.mutableValue = this.mutableValue.filter(entry => entry !== ref)
         } else {
           this.mutableValue = null
         }

Original file line number	Diff line number	Diff line change
`@@ -844,7 +844,7 @@`
`844`	`844`	`if (this.multiple && !this.mutableValue) {`
`845`	`845`	`this.mutableValue = [option]`
`846`	`846`	`} else if (this.multiple) {`
`847`		`- this.mutableValue.push(option)`
	`847`	`+ this.mutableValue = [...this.mutableValue, option]`
`848`	`848`	`} else {`
`849`	`849`	`this.mutableValue = option`
`850`	`850`	`}`
`@@ -867,8 +867,7 @@`
`867`	`867`	`ref = val`
`868`	`868`	`}`
`869`	`869`	`})`
`870`		`- var index = this.mutableValue.indexOf(ref)`
`871`		`- this.mutableValue.splice(index, 1)`
	`870`	`+ this.mutableValue = this.mutableValue.filter(entry => entry !== ref)`
`872`	`871`	`} else {`
`873`	`872`	`this.mutableValue = null`
`874`	`873`	`}`