Don't mutate existing value. Change missing from PR sagalbot#702 (sagalbot#789)

hrobertson · sagalbot · commit e76e3c966bc8 · 2019-03-22T10:48:51.000-07:00
diff --git a/src/components/Select.vue b/src/components/Select.vue
@@ -1029,7 +1029,7 @@
        */
       maybeDeleteValue() {
         if (!this.$refs.search.value.length && this.mutableValue && this.clearable) {
-          return this.multiple ? this.mutableValue.pop() : this.mutableValue = null
+          this.mutableValue = this.multiple ? this.mutableValue.slice(0, -1) : null
         }
       },
 

Original file line number	Diff line number	Diff line change
`@@ -1029,7 +1029,7 @@`
`1029`	`1029`	`*/`
`1030`	`1030`	`maybeDeleteValue() {`
`1031`	`1031`	`if (!this.$refs.search.value.length && this.mutableValue && this.clearable) {`
`1032`		`- return this.multiple ? this.mutableValue.pop() : this.mutableValue = null`
	`1032`	`+ this.mutableValue = this.multiple ? this.mutableValue.slice(0, -1) : null`
`1033`	`1033`	`}`
`1034`	`1034`	`},`
`1035`	`1035`