Hexagonal pattern: Improve error handling in console lottery

iluwatar · iluwatar · commit c4c5e78e50f6 · 2016-09-14T22:18:42.000+03:00
diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java
@@ -79,37 +79,45 @@ public static void main(String[] args) {
         PlayerDetails details = PlayerDetails.create(email, account, phone);
         System.out.println("Give 4 comma separated lottery numbers?");
         String numbers = readString(scanner);
-        String[] parts = numbers.split(",");
-        Set<Integer> chosen = new HashSet<>();
-        for (int i = 0; i < 4; i++) {
-          chosen.add(Integer.parseInt(parts[i]));
-        }
-        LotteryNumbers lotteryNumbers = LotteryNumbers.create(chosen);
-        LotteryTicket lotteryTicket = LotteryTicket.create(new LotteryTicketId(), details, lotteryNumbers);
-        Optional<LotteryTicketId> id = service.submitTicket(lotteryTicket);
-        if (id.isPresent()) {
-          System.out.println("Submitted lottery ticket with id: " + id.get());
-        } else {
+        try {
+          String[] parts = numbers.split(",");
+          Set<Integer> chosen = new HashSet<>();
+          for (int i = 0; i < 4; i++) {
+            chosen.add(Integer.parseInt(parts[i]));
+          }
+          LotteryNumbers lotteryNumbers = LotteryNumbers.create(chosen);
+          LotteryTicket lotteryTicket = LotteryTicket.create(new LotteryTicketId(), details, lotteryNumbers);
+          Optional<LotteryTicketId> id = service.submitTicket(lotteryTicket);
+          if (id.isPresent()) {
+            System.out.println("Submitted lottery ticket with id: " + id.get());
+          } else {
+            System.out.println("Failed submitting lottery ticket - please try again.");
+          }
+        } catch (Exception e) {
           System.out.println("Failed submitting lottery ticket - please try again.");
         }
       } else if (cmd.equals("4")) {
         System.out.println("What is the ID of the lottery ticket?");
         String id = readString(scanner);
         System.out.println("Give the 4 comma separated winning numbers?");
         String numbers = readString(scanner);
-        String[] parts = numbers.split(",");
-        Set<Integer> winningNumbers = new HashSet<>();
-        for (int i = 0; i < 4; i++) {
-          winningNumbers.add(Integer.parseInt(parts[i]));
-        }
-        LotteryTicketCheckResult result = service.checkTicketForPrize(
-            new LotteryTicketId(Integer.parseInt(id)), LotteryNumbers.create(winningNumbers));
-        if (result.getResult().equals(LotteryTicketCheckResult.CheckResult.WIN_PRIZE)) {
-          System.out.println("Congratulations! The lottery ticket has won!");
-        } else if (result.getResult().equals(LotteryTicketCheckResult.CheckResult.NO_PRIZE)) {
-          System.out.println("Unfortunately the lottery ticket did not win.");
-        } else {
-          System.out.println("Such lottery ticket has not been submitted.");
+        try {
+          String[] parts = numbers.split(",");
+          Set<Integer> winningNumbers = new HashSet<>();
+          for (int i = 0; i < 4; i++) {
+            winningNumbers.add(Integer.parseInt(parts[i]));
+          }
+          LotteryTicketCheckResult result = service.checkTicketForPrize(
+              new LotteryTicketId(Integer.parseInt(id)), LotteryNumbers.create(winningNumbers));
+          if (result.getResult().equals(LotteryTicketCheckResult.CheckResult.WIN_PRIZE)) {
+            System.out.println("Congratulations! The lottery ticket has won!");
+          } else if (result.getResult().equals(LotteryTicketCheckResult.CheckResult.NO_PRIZE)) {
+            System.out.println("Unfortunately the lottery ticket did not win.");
+          } else {
+            System.out.println("Such lottery ticket has not been submitted.");
+          }
+        } catch (Exception e) {
+          System.out.println("Failed checking the lottery ticket - please try again.");
         }
       } else if (cmd.equals("5")) {
         exit = true;
